linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* 2.6.33-rc6 regression: mdadm Unknown cmd 800c0910 (RAID_VERSION)
@ 2010-01-30 20:53 Michael S. Tsirkin
  2010-01-30 22:02 ` compat_ioctl: ignore RAID_VERSION ioctl Arnd Bergmann
  0 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2010-01-30 20:53 UTC (permalink / raw)
  To: Rafael J. Wysocki
  Cc: Linux Kernel Mailing List, neilb, linux-raid, dm-devel, arnd,
	maan

Under 2.6.33-rcX (at least rc5 and rc6, didn't check earlier versions),
I started seeing these messages in dmesg (I do not see these messages on 2.6.32):

[   16.528951] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda9
[   16.529570] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9e4) on /dev/sda9
[   16.553175] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda7
[   16.553846] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9e4) on /dev/sda7
[   16.577349] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda6
[   16.577954] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9e4) on /dev/sda6
[   16.684570] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda5
[   16.695916] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9e4) on /dev/sda5
[   16.702729] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda2
[   16.702743] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9e4) on /dev/sda2
[   16.747168] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda1
[   16.747786] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9e4) on /dev/sda1

I am running 32 bit userspace on 64 bit kernel.

I do not observe any ill effects, possibly because I do not really use raid.

The command in question seems to be RAID_VERSION.

I have verified that reverting
aa98aa31987ad9831711ae71ea2270228ab62532
makes the errors go away.

Didn't yet bother opening a bugzilla for this, let me know if I should.

-- 
MST

^ permalink raw reply	[flat|nested] 5+ messages in thread

* compat_ioctl: ignore RAID_VERSION ioctl
  2010-01-30 20:53 2.6.33-rc6 regression: mdadm Unknown cmd 800c0910 (RAID_VERSION) Michael S. Tsirkin
@ 2010-01-30 22:02 ` Arnd Bergmann
  2010-01-31  9:03   ` Michael S. Tsirkin
  2010-02-07  9:24   ` Michael S. Tsirkin
  0 siblings, 2 replies; 5+ messages in thread
From: Arnd Bergmann @ 2010-01-30 22:02 UTC (permalink / raw)
  To: Michael S. Tsirkin
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List, neilb, linux-raid,
	dm-devel, maan

md ioctls are now handled by the md driver itself, but mdadm
may call RAID_VERSION on other devices as well. Mark the command
as IGNORE_IOCTL so this fails silently rather than printing
an annoying message.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---

On Saturday 30 January 2010, Michael S. Tsirkin wrote:
> Under 2.6.33-rcX (at least rc5 and rc6, didn't check earlier versions),
> I started seeing these messages in dmesg (I do not see these messages on 2.6.32):
> 
> [   16.528951] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda9

Does this help?

--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -1038,6 +1038,8 @@ COMPATIBLE_IOCTL(FIOQSIZE)
 #ifdef CONFIG_BLOCK
 /* loop */
 IGNORE_IOCTL(LOOP_CLR_FD)
+/* md calls this on random blockdevs */
+IGNORE_IOCTL(RAID_VERSION)
 /* SG stuff */
 COMPATIBLE_IOCTL(SG_SET_TIMEOUT)
 COMPATIBLE_IOCTL(SG_GET_TIMEOUT)


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: compat_ioctl: ignore RAID_VERSION ioctl
  2010-01-30 22:02 ` compat_ioctl: ignore RAID_VERSION ioctl Arnd Bergmann
@ 2010-01-31  9:03   ` Michael S. Tsirkin
  2010-02-07  9:24   ` Michael S. Tsirkin
  1 sibling, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2010-01-31  9:03 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List, neilb, linux-raid,
	dm-devel, maan

On Sat, Jan 30, 2010 at 11:02:10PM +0100, Arnd Bergmann wrote:
> md ioctls are now handled by the md driver itself, but mdadm
> may call RAID_VERSION on other devices as well. Mark the command
> as IGNORE_IOCTL so this fails silently rather than printing
> an annoying message.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> 
> On Saturday 30 January 2010, Michael S. Tsirkin wrote:
> > Under 2.6.33-rcX (at least rc5 and rc6, didn't check earlier versions),
> > I started seeing these messages in dmesg (I do not see these messages on 2.6.32):
> > 
> > [   16.528951] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda9
> 
> Does this help?

Yes, this fixes it.

> --- a/fs/compat_ioctl.c
> +++ b/fs/compat_ioctl.c
> @@ -1038,6 +1038,8 @@ COMPATIBLE_IOCTL(FIOQSIZE)
>  #ifdef CONFIG_BLOCK
>  /* loop */
>  IGNORE_IOCTL(LOOP_CLR_FD)
> +/* md calls this on random blockdevs */
> +IGNORE_IOCTL(RAID_VERSION)
>  /* SG stuff */
>  COMPATIBLE_IOCTL(SG_SET_TIMEOUT)
>  COMPATIBLE_IOCTL(SG_GET_TIMEOUT)
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: compat_ioctl: ignore RAID_VERSION ioctl
  2010-01-30 22:02 ` compat_ioctl: ignore RAID_VERSION ioctl Arnd Bergmann
  2010-01-31  9:03   ` Michael S. Tsirkin
@ 2010-02-07  9:24   ` Michael S. Tsirkin
  2010-02-07 10:03     ` Rafael J. Wysocki
  1 sibling, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2010-02-07  9:24 UTC (permalink / raw)
  To: Arnd Bergmann
  Cc: Rafael J. Wysocki, Linux Kernel Mailing List, neilb, linux-raid,
	dm-devel, maan

On Sat, Jan 30, 2010 at 11:02:10PM +0100, Arnd Bergmann wrote:
> md ioctls are now handled by the md driver itself, but mdadm
> may call RAID_VERSION on other devices as well. Mark the command
> as IGNORE_IOCTL so this fails silently rather than printing
> an annoying message.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

The patch does not seem to be there in -rc7.
Since this is fixes a regression, should this go into 2.6.33?
Thanks!

> ---
> 
> On Saturday 30 January 2010, Michael S. Tsirkin wrote:
> > Under 2.6.33-rcX (at least rc5 and rc6, didn't check earlier versions),
> > I started seeing these messages in dmesg (I do not see these messages on 2.6.32):
> > 
> > [   16.528951] ioctl32(mdadm:2243): Unknown cmd fd(3) cmd(800c0910){t:09;sz:12} arg(ffb7f9c4) on /dev/sda9
> 
> Does this help?
> 
> --- a/fs/compat_ioctl.c
> +++ b/fs/compat_ioctl.c
> @@ -1038,6 +1038,8 @@ COMPATIBLE_IOCTL(FIOQSIZE)
>  #ifdef CONFIG_BLOCK
>  /* loop */
>  IGNORE_IOCTL(LOOP_CLR_FD)
> +/* md calls this on random blockdevs */
> +IGNORE_IOCTL(RAID_VERSION)
>  /* SG stuff */
>  COMPATIBLE_IOCTL(SG_SET_TIMEOUT)
>  COMPATIBLE_IOCTL(SG_GET_TIMEOUT)
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: compat_ioctl: ignore RAID_VERSION ioctl
  2010-02-07  9:24   ` Michael S. Tsirkin
@ 2010-02-07 10:03     ` Rafael J. Wysocki
  0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2010-02-07 10:03 UTC (permalink / raw)
  To: Michael S. Tsirkin
  Cc: Arnd Bergmann, Linux Kernel Mailing List, neilb, linux-raid,
	dm-devel, maan

On Sunday 07 February 2010, Michael S. Tsirkin wrote:
> On Sat, Jan 30, 2010 at 11:02:10PM +0100, Arnd Bergmann wrote:
> > md ioctls are now handled by the md driver itself, but mdadm
> > may call RAID_VERSION on other devices as well. Mark the command
> > as IGNORE_IOCTL so this fails silently rather than printing
> > an annoying message.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> The patch does not seem to be there in -rc7.
> Since this is fixes a regression, should this go into 2.6.33?

I guess it should.

Do you have a link to the original report or has it been sent privately?

Rafael

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2010-02-07 10:03 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-30 20:53 2.6.33-rc6 regression: mdadm Unknown cmd 800c0910 (RAID_VERSION) Michael S. Tsirkin
2010-01-30 22:02 ` compat_ioctl: ignore RAID_VERSION ioctl Arnd Bergmann
2010-01-31  9:03   ` Michael S. Tsirkin
2010-02-07  9:24   ` Michael S. Tsirkin
2010-02-07 10:03     ` Rafael J. Wysocki

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).