linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neil Brown <neilb@suse.de>
To: "Trela, Maciej" <Maciej.Trela@intel.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"Ciechanowski, Ed" <ed.ciechanowski@intel.com>
Subject: Re: [PATCH 4/4] md: Enable takeover for external metadata
Date: Wed, 10 Feb 2010 16:57:10 +1100	[thread overview]
Message-ID: <20100210165710.11493bc5@notabene.brown> (raw)
In-Reply-To: <F2A46F4A087B8547923AD59C289DC90E01DCD389@irsmsx002.ger.corp.intel.com>

On Wed, 3 Feb 2010 12:29:53 +0000
"Trela, Maciej" <Maciej.Trela@intel.com> wrote:

> 
> This is one more patch for md takeover that was accidentally skipped while sending...
> Please, apply it together with the rest of md takeover patches.
> 
> Now md will notify mdmon about the level change.
> Also sysfs redundancy_group specific to non-raid0 is now handled when switching personalities.
> 


Thanks for these.

You should get into the habit of checking your patches
with ./scripts/checkpatch.pl.  There was lots of stray white space and
various other issues.  I have fixed them.  You can find the current patches
in my "md-scatch" branch:
  http://neil.brown.name/git?p=md;a=shortlog;h=refs/heads/md-scratch

I also fixed some other little issues like the fact that you don't want to
set ->delta_disks when converting between RAID0 and RAID5.

I think there are still some issues with error handling if kzalloc fails
while allocating the new 'private' structures.   I'll have another run
through the patches in a few days and see what else I can fix it.

I seem to have misplaced the mdadm patches.  If you would like to send those
again I will have a look and possibly apply them.

Thanks,
NeilBrown

  reply	other threads:[~2010-02-10  5:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-29 14:54 [PATCH 3/3] md: Add support for Raid0->Raid10 takeover Trela, Maciej
2010-02-01  0:08 ` Neil Brown
2010-02-03 12:16   ` Trela, Maciej
2010-02-03 12:29   ` [PATCH 4/4] md: Enable takeover for external metadata Trela, Maciej
2010-02-10  5:57     ` Neil Brown [this message]
2010-02-10 17:36       ` Dan Williams
2010-02-11 12:34         ` Trela, Maciej

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100210165710.11493bc5@notabene.brown \
    --to=neilb@suse.de \
    --cc=Maciej.Trela@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ed.ciechanowski@intel.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).