From: Neil Brown <neilb@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-raid@vger.kernel.org, Luca Berra <bluca@comedia.it>
Subject: Re: [PATCH] Fixup default definitions of VAR_RUN and ALT_RUN
Date: Thu, 15 Apr 2010 15:30:23 +1000 [thread overview]
Message-ID: <20100415153023.24c4dac3@notabene.brown> (raw)
In-Reply-To: <20100414185356.29125.69103.stgit@dwillia2-linux.jf.intel.com>
On Wed, 14 Apr 2010 11:53:56 -0700
Dan Williams <dan.j.williams@intel.com> wrote:
> I suspect commit c132678b wanted VAR_RUN and ALT_RUN to be suffixed by
> '/mdadm' to match the defaults in mdadm.h.
Bother! Yes, thanks, applied.
NeilBrown
>
> Cc: Luca Berra <bluca@comedia.it>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>
> Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 1035ea8..74dafa4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -62,8 +62,8 @@ CONFFILEFLAGS = -DCONFFILE=\"$(CONFFILE)\" -DCONFFILE2=\"$(CONFFILE2)\"
> # from early boot to late boot.
> # If you don't have /lib/init/rw you might want to use /dev/.something
> # e.g. make ALT_RUN=/dev/.mdadm
> -ALT_RUN = /lib/init/rw
> -VAR_RUN = /var/run
> +ALT_RUN = /lib/init/rw/mdadm
> +VAR_RUN = /var/run/mdadm
> ALTFLAGS = -DALT_RUN=\"$(ALT_RUN)\"
> VARFLAGS = -DVAR_RUN=\"$(VAR_RUN)\"
> CFLAGS = $(CWFLAGS) $(CXFLAGS) -DSendmail=\""$(MAILCMD)"\" $(CONFFILEFLAGS) $(ALTFLAGS) $(VARFLAGS)
prev parent reply other threads:[~2010-04-15 5:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-14 18:53 [PATCH] Fixup default definitions of VAR_RUN and ALT_RUN Dan Williams
2010-04-15 5:30 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415153023.24c4dac3@notabene.brown \
--to=neilb@suse.de \
--cc=bluca@comedia.it \
--cc=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).