* [PATCH] Fixup default definitions of VAR_RUN and ALT_RUN
@ 2010-04-14 18:53 Dan Williams
2010-04-15 5:30 ` Neil Brown
0 siblings, 1 reply; 2+ messages in thread
From: Dan Williams @ 2010-04-14 18:53 UTC (permalink / raw)
To: neilb; +Cc: linux-raid, Luca Berra, Dan Williams
I suspect commit c132678b wanted VAR_RUN and ALT_RUN to be suffixed by
'/mdadm' to match the defaults in mdadm.h.
Cc: Luca Berra <bluca@comedia.it>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
Makefile | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile b/Makefile
index 1035ea8..74dafa4 100644
--- a/Makefile
+++ b/Makefile
@@ -62,8 +62,8 @@ CONFFILEFLAGS = -DCONFFILE=\"$(CONFFILE)\" -DCONFFILE2=\"$(CONFFILE2)\"
# from early boot to late boot.
# If you don't have /lib/init/rw you might want to use /dev/.something
# e.g. make ALT_RUN=/dev/.mdadm
-ALT_RUN = /lib/init/rw
-VAR_RUN = /var/run
+ALT_RUN = /lib/init/rw/mdadm
+VAR_RUN = /var/run/mdadm
ALTFLAGS = -DALT_RUN=\"$(ALT_RUN)\"
VARFLAGS = -DVAR_RUN=\"$(VAR_RUN)\"
CFLAGS = $(CWFLAGS) $(CXFLAGS) -DSendmail=\""$(MAILCMD)"\" $(CONFFILEFLAGS) $(ALTFLAGS) $(VARFLAGS)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fixup default definitions of VAR_RUN and ALT_RUN
2010-04-14 18:53 [PATCH] Fixup default definitions of VAR_RUN and ALT_RUN Dan Williams
@ 2010-04-15 5:30 ` Neil Brown
0 siblings, 0 replies; 2+ messages in thread
From: Neil Brown @ 2010-04-15 5:30 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-raid, Luca Berra
On Wed, 14 Apr 2010 11:53:56 -0700
Dan Williams <dan.j.williams@intel.com> wrote:
> I suspect commit c132678b wanted VAR_RUN and ALT_RUN to be suffixed by
> '/mdadm' to match the defaults in mdadm.h.
Bother! Yes, thanks, applied.
NeilBrown
>
> Cc: Luca Berra <bluca@comedia.it>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>
> Makefile | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 1035ea8..74dafa4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -62,8 +62,8 @@ CONFFILEFLAGS = -DCONFFILE=\"$(CONFFILE)\" -DCONFFILE2=\"$(CONFFILE2)\"
> # from early boot to late boot.
> # If you don't have /lib/init/rw you might want to use /dev/.something
> # e.g. make ALT_RUN=/dev/.mdadm
> -ALT_RUN = /lib/init/rw
> -VAR_RUN = /var/run
> +ALT_RUN = /lib/init/rw/mdadm
> +VAR_RUN = /var/run/mdadm
> ALTFLAGS = -DALT_RUN=\"$(ALT_RUN)\"
> VARFLAGS = -DVAR_RUN=\"$(VAR_RUN)\"
> CFLAGS = $(CWFLAGS) $(CXFLAGS) -DSendmail=\""$(MAILCMD)"\" $(CONFFILEFLAGS) $(ALTFLAGS) $(VARFLAGS)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-15 5:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-14 18:53 [PATCH] Fixup default definitions of VAR_RUN and ALT_RUN Dan Williams
2010-04-15 5:30 ` Neil Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).