From: Dave Chinner <david@fromorbit.com>
To: Doug Ledford <dledford@redhat.com>
Cc: Rainer Fuegenstein <rfu@kaneda.iguw.tuwien.ac.at>,
xfs@oss.sgi.com, linux-raid@vger.kernel.org
Subject: Re: xfs and raid5 - "Structure needs cleaning for directory open"
Date: Tue, 18 May 2010 07:45:32 +1000 [thread overview]
Message-ID: <20100517214532.GL8120@dastard> (raw)
In-Reply-To: <4BF1B4FE.7020503@redhat.com>
On Mon, May 17, 2010 at 05:28:30PM -0400, Doug Ledford wrote:
> On 05/09/2010 10:20 PM, Dave Chinner wrote:
> > On Sun, May 09, 2010 at 08:48:00PM +0200, Rainer Fuegenstein wrote:
> >>
> >> today in the morning some daemon processes terminated because of
> >> errors in the xfs file system on top of a software raid5, consisting
> >> of 4*1.5TB WD caviar green SATA disks.
> >
> > Reminds me of a recent(-ish) md/dm readahead cancellation fix - that
> > would fit the symptoms of (btree corruption showing up under heavy IO
> > load but no corruption on disk. However, I can't seem to find any
> > references to it at the moment (can't remember the bug title), but
> > perhaps your distro doesn't have the fix in it?
> >
> > Cheers,
> >
> > Dave.
>
> That sounds plausible, as does hardware error. A memory bit flip under
> heavy load would cause the in memory data to be corrupt while the on
> disk data is good.
The data dumps from the bad blocks weren't wrong by a single bit -
they were unrecogniѕable garbage - so that it very unlikely to be
a memory erro causing the problem.
> By waiting to check it until later, the bad memory
> was flushed at some point and when the data was reloaded it came in ok
> this time.
Yup - XFS needs to do a better job of catching this case - the
prototype metadata checksumming patch caught most of these cases...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-05-17 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1743435018.20100510013511@kaneda.iguw.tuwien.ac.at>
[not found] ` <462402327.20100509210710@kaneda.iguw.tuwien.ac.at>
2010-05-09 18:48 ` xfs and raid5 - "Structure needs cleaning for directory open" Rainer Fuegenstein
2010-05-10 2:20 ` Dave Chinner
2010-05-17 21:28 ` Doug Ledford
2010-05-17 21:45 ` Dave Chinner [this message]
2010-05-17 22:18 ` Doug Ledford
2010-05-17 23:04 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517214532.GL8120@dastard \
--to=david@fromorbit.com \
--cc=dledford@redhat.com \
--cc=linux-raid@vger.kernel.org \
--cc=rfu@kaneda.iguw.tuwien.ac.at \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).