From: Christoph Hellwig <hch@lst.de>
To: Neil Brown <neilb@suse.de>
Cc: Jiri Slaby <jirislaby@gmail.com>,
James Bottomley <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org, hch@lst.de, jaxboe@fusionio.com,
LKML <linux-kernel@vger.kernel.org>,
linux-raid@vger.kernel.org
Subject: Re: BUG at drivers/scsi/scsi_lib.c:1113
Date: Thu, 22 Jul 2010 10:36:10 +0200 [thread overview]
Message-ID: <20100722083609.GA4435@lst.de> (raw)
In-Reply-To: <20100722173716.66264bef@notabene>
On Thu, Jul 22, 2010 at 05:37:16PM +1000, Neil Brown wrote:
> I suspect that problem is that "do_sync" and "do_barriers" in
> drivers/md/raid1.c are still 'bool' and should now be 'unsigned long'.
>
> I'm not sure how wide '_Bool' is, but I'm guess it isn't wide enough.
>
> Could you please try changing ever 'bool' in that file to 'unsigned long'
> and see if that fixes it?
Yes, that fixes it. We even had someone sending that fix a while ago,
but it seems it's not applied to Jens' tree yet and I can't find it
anymore either right now.
next prev parent reply other threads:[~2010-07-22 8:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 7:04 BUG at drivers/scsi/scsi_lib.c:1113 Jiri Slaby
2010-07-22 7:37 ` Neil Brown
2010-07-22 8:06 ` Jiri Slaby
2010-07-22 8:36 ` Christoph Hellwig [this message]
2010-07-22 8:39 ` Jiri Slaby
2010-07-22 10:39 ` Boaz Harrosh
2010-07-22 11:44 ` [PATCH] md: bitwise operations might not fit in a "bool" Boaz Harrosh
2010-07-22 11:55 ` Neil Brown
2010-07-22 12:20 ` Boaz Harrosh
2010-07-22 12:37 ` Neil Brown
2010-07-27 22:27 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100722083609.GA4435@lst.de \
--to=hch@lst.de \
--cc=James.Bottomley@suse.de \
--cc=jaxboe@fusionio.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).