linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org
Subject: [mdadm PATCH 2/2] Incremental: accept '--no-degraded' as a deprecated option
Date: Tue, 10 Aug 2010 09:46:48 -0700	[thread overview]
Message-ID: <20100810164648.26691.16684.stgit@localhost.localdomain> (raw)
In-Reply-To: <20100810164551.26691.17944.stgit@localhost.localdomain>

Commit 3288b419 (Revert "Incremental: honor --no-degraded to delay assembly")
killed the --no-degraded flag since commit 97b4d0e9 (Incremental: honor
an 'enough' flag from external handlers) made this the default behavior
of -I, and brought -I usage for external/container formats in line with
native metadata.  However, this breaks existing usages of '-I
--no-degraded', so allow it as a deprecated option.

Starting a degraded container, like the native metadata case, requires -R.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 mdadm.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/mdadm.c b/mdadm.c
index 20a5638..08e8ea4 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -691,6 +691,8 @@ int main(int argc, char *argv[])
 		"     'summaries', 'homehost', 'byteorder', 'devicesize'.\n");
 			exit(outf == stdout ? 0 : 2);
 
+		case O(INCREMENTAL,NoDegraded):
+			fprintf(stderr, Name ": --no-degraded is deprecated in Incremental mode\n");
 		case O(ASSEMBLE,NoDegraded): /* --no-degraded */
 			runstop = -1; /* --stop isn't allowed for --assemble,
 				       * so we overload slightly */


  parent reply	other threads:[~2010-08-10 16:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-10 16:46 [mdadm PATCH 0/2] two 3.1.3 regression fixes (incremental assembly) Dan Williams
2010-08-10 16:46 ` [mdadm PATCH 1/2] Incremental: return success in 'container not enough' case Dan Williams
2010-08-10 16:46 ` Dan Williams [this message]
2010-08-10 23:40 ` [mdadm PATCH 0/2] two 3.1.3 regression fixes (incremental assembly) Dan Williams
2010-08-12  1:22   ` Neil Brown
2010-08-12  1:47 ` Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100810164648.26691.16684.stgit@localhost.localdomain \
    --to=dan.j.williams@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).