From: Christoph Hellwig <hch@lst.de>
To: Jiri Slaby <jslaby@suse.cz>
Cc: akpm@linux-foundation.org, linux-raid@vger.kernel.org,
linux-scsi@vger.kernel.org, jirislaby@gmail.com,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH v2] BLOCK: fix bio.bi_rw handling
Date: Thu, 12 Aug 2010 18:08:09 +0200 [thread overview]
Message-ID: <20100812160809.GC28689@lst.de> (raw)
In-Reply-To: <1281616266-4709-3-git-send-email-jslaby@suse.cz>
On Thu, Aug 12, 2010 at 02:31:06PM +0200, Jiri Slaby wrote:
> Return of the bi_rw tests is no longer bool after commit 74450be1. But
> results of such tests are stored in bools. This doesn't fit in there
> for some compilers (gcc 4.5 here), so either use !! magic to get real
> bools or use ulong where the result is assigned somewhere.
I'd have to look at my copy of the C standard if it's guaranteed, but
at least currently the values just get truncated down and bool still
is set to true. I'd much prefer just making these flags unsigned longs
instead of adding syntactic surage to make them true bools.
next prev parent reply other threads:[~2010-08-12 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-12 12:31 [PATCH v2] MD: raid, fix BUG caused by flags handling Jiri Slaby
2010-08-12 12:31 ` [PATCH v2] SCSI: fix bio.bi_rw handling Jiri Slaby
2010-08-12 13:30 ` Jeff Moyer
2010-08-12 16:06 ` Christoph Hellwig
2010-08-12 12:31 ` [PATCH v2] BLOCK: " Jiri Slaby
2010-08-12 13:35 ` Jeff Moyer
2010-08-12 16:08 ` Christoph Hellwig [this message]
2010-08-12 16:24 ` Jiri Slaby
2010-08-23 10:33 ` Jens Axboe
2010-08-12 13:26 ` [PATCH v2] MD: raid, fix BUG caused by flags handling Jeff Moyer
2010-08-12 16:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100812160809.GC28689@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=jirislaby@gmail.com \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).