From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Snitzer Subject: Re: [PATCH 1/4] block: make __blk_rq_prep_clone() copy most command flags Date: Fri, 27 Aug 2010 13:57:11 -0400 Message-ID: <20100827175711.GB23680@redhat.com> References: <1282929060-23663-1-git-send-email-tj@kernel.org> <1282929060-23663-2-git-send-email-tj@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1282929060-23663-2-git-send-email-tj@kernel.org> Sender: linux-raid-owner@vger.kernel.org To: Tejun Heo Cc: jaxboe@fusionio.com, k-ueda@ct.jp.nec.com, j-nomura@ce.jp.nec.com, jamie@shareable.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-raid@vger.kernel.org, hch@lst.de List-Id: linux-raid.ids On Fri, Aug 27 2010 at 1:10pm -0400, Tejun Heo wrote: > Currently __blk_rq_prep_clone() copies only REQ_WRITE and REQ_DISCARD. > There's no reason to omit other command flags and REQ_FUA needs to be > copied to implement FUA support in request-based dm. > > REQ_COMMON_MASK which specifies flags to be copied from bio to request > already identifies all the command flags. Define REQ_CLONE_MASK to be > the same as REQ_COMMON_MASK for clarity and make __blk_rq_prep_clone() > copy all flags in the mask. > > Signed-off-by: Tejun Heo Looks great. Acked-by: Mike Snitzer