From: Dan Williams <dan.j.williams@intel.com>
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, wojciech.neubauer@intel.com,
adam.kwolek@intel.com, marcin.labun@intel.com,
ed.ciechanowski@intel.com
Subject: [PATCH 2/2] md/raid5: initialize ->recovery_offset when growing raid_disks
Date: Fri, 22 Oct 2010 11:03:59 -0700 [thread overview]
Message-ID: <20101022180359.6563.11717.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20101022180311.6563.6666.stgit@localhost6.localdomain6>
We mark the disk in-sync, and also need to init ->recovery_offset lest
we confuse older versions of mdadm that don't consider this case at
assembly (i.e. that when growing we assume the disk is insync).
mdadm: /dev/md0 assembled from 3 drives and 1 rebuilding - not enough to start the array.
Cc: <stable@kernel.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/md/raid5.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 9e8ecd5..f8a27d4 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -5580,6 +5580,7 @@ static int raid5_start_reshape(mddev_t *mddev)
if (raid5_add_disk(mddev, rdev) == 0) {
char nm[20];
if (rdev->raid_disk >= conf->previous_raid_disks) {
+ rdev->recovery_offset = MaxSector;
set_bit(In_sync, &rdev->flags);
added_devices++;
} else
next prev parent reply other threads:[~2010-10-22 18:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 18:03 [PATCH 0/2] reshape fixlets for 2.6.37 Dan Williams
2010-10-22 18:03 ` [PATCH 1/2] md/raid5: skip wait for MD_CHANGE_DEVS acknowledgement in the external case Dan Williams
2010-10-26 5:22 ` Neil Brown
2010-10-26 7:20 ` Dan Williams
2010-10-22 18:03 ` Dan Williams [this message]
2010-10-26 5:35 ` [PATCH 2/2] md/raid5: initialize ->recovery_offset when growing raid_disks Neil Brown
2010-10-26 7:26 ` Dan Williams
2010-10-26 7:54 ` Neil Brown
2010-10-26 8:43 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101022180359.6563.11717.stgit@localhost6.localdomain6 \
--to=dan.j.williams@intel.com \
--cc=adam.kwolek@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=marcin.labun@intel.com \
--cc=neilb@suse.de \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).