From: Neil Brown <neilb@suse.de>
To: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
Cc: linux-raid@vger.kernel.org, wojciech.neubauer@intel.com,
adam.kwolek@intel.com, dan.j.williams@intel.com,
ed.ciechanowski@intel.com
Subject: Re: [PATCH 02/13] block monitor: freeze spare assignment for external arrays
Date: Tue, 23 Nov 2010 15:03:35 +1100 [thread overview]
Message-ID: <20101123150335.1d0e15a1@notabene.brown> (raw)
In-Reply-To: <20101118092137.29508.66427.stgit@gklab-170-111.igk.intel.com>
I've applied 1/13 to devel-3.2
and if have applied this (2/13) with a few changes:
> + version = ping_monitor_version(container);
> + ver = version ? mdadm_version(version) : -1;
> + free(version);
> + if (ver < 3001003) {
I changed this to 3002000 and changed ReadMe.c so the version is 3.2-devel.
>
> +int mdadm_version(char *version)
> +{
> + int a, b, c;
> + char *cp;
> +
> + if (!version)
> + version = Version;
> +
> + cp = strchr(version, '-');
> + if (!cp || *(cp+1) != ' ' || *(cp+2) != 'v')
> + return -1;
> + cp += 3;
> + a = strtoul(cp, &cp, 10);
> + if (*cp != '.')
> + return -1;
> + b = strtoul(cp+1, &cp, 10);
> + if (*cp != '.')
> + return -1;
> + c = strtoul(cp+1, &cp, 10);
> + if (*cp != ' ')
> + return -1;
> + return (a*1000000)+(b*1000)+c;
> +}
> +
I have fixed this so that it access 2 number versions, and ignores a trailing
"-tag", so 3.2-devel is parsed OK.
NeilBrown
next prev parent reply other threads:[~2010-11-23 4:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 9:21 [PATCH 00/13] Series short description Krzysztof Wojcik
2010-11-18 9:21 ` [PATCH 01/13] Provide a mdstat_ent to subarray helper Krzysztof Wojcik
2010-11-18 9:21 ` [PATCH 02/13] block monitor: freeze spare assignment for external arrays Krzysztof Wojcik
2010-11-23 4:03 ` Neil Brown [this message]
2010-11-18 9:21 ` [PATCH 03/13] Manage: allow manual control of external raid0 readonly flag Krzysztof Wojcik
2010-11-23 4:08 ` Neil Brown
2010-11-18 9:21 ` [PATCH 04/13] Grow: mark some functions static Krzysztof Wojcik
2010-11-18 9:22 ` [PATCH 05/13] Assemble: fix assembly in the delta_disks > max_degraded case Krzysztof Wojcik
2010-11-18 9:22 ` [PATCH 06/13] Grow: fix check for raid6 layout normalization Krzysztof Wojcik
2010-11-18 9:22 ` [PATCH 07/13] Grow: add missing raid4 geometries to geo_map() Krzysztof Wojcik
2010-11-23 4:16 ` Neil Brown
2010-11-18 9:22 ` [PATCH 08/13] fix a get_linux_version() comparison typo Krzysztof Wojcik
2010-11-18 9:22 ` [PATCH 09/13] Create: cleanup/unify default geometry handling Krzysztof Wojcik
2010-11-18 9:22 ` [PATCH 10/13] Initialize st->devnum and st->container_dev in super_by_fd Krzysztof Wojcik
2010-11-18 9:22 ` [PATCH 11/13] Document the external reshape implementation Krzysztof Wojcik
2010-11-23 4:52 ` Neil Brown
2010-11-18 9:22 ` [PATCH 12/13] External reshape (step 1): container reshape and ->reshape_super() Krzysztof Wojcik
2010-11-23 5:22 ` Neil Brown
2010-11-18 9:23 ` [PATCH 13/13] External reshape (step 2): Freeze container Krzysztof Wojcik
2010-11-23 6:11 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101123150335.1d0e15a1@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=krzysztof.wojcik@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).