Re: [PATCH] Monitor: few bug fixes for spare migration

[Neil Brown <neilb@suse.de>]

On Thu, 25 Nov 2010 17:28:29 +0000 "Czarnowska, Anna"
<anna.czarnowska@intel.com> wrote:

> >From bbe35756559c6bee0309ce7ebae668c53d5e1a74 Mon Sep 17 00:00:00 2001
> From: Anna Czarnowska <anna.czarnowska@intel.com>
> Date: Thu, 25 Nov 2010 18:25:03 +0100
> Subject: [PATCH] Monitor: few bug fixes for spare migration
> Cc: linux-raid@vger.kernel.org, Williams, Dan J <dan.j.williams@intel.com>, Ciechanowski, Ed <ed.ciechanowski@intel.com>
> 
> 1. If array not changed we should still report anydegraded
> - another array may have got a new spare that we can move.
> 2. Array with err=1 can't give a spare.
> 3. Spares can't be migrated between different metadata arrays.

I meant the mention this before - thanks for the reminder.

Why do you want to forbid spare migration between different metadata arrays??

If an admin wanted to impose this restriction they could easily use domains -
a different domain for each metadata type.
But if there a good reason to insist on this in the code in a way that the
sysadmin cannot over-ride it?


> 4. We look for spares in "from" not "st" which is supertype
> and has devname=NULL.

Thanks!  The other 3 changes are all good.  I have applied the patch with the
metadata type check removed for now.

NeilBrown