From: Neil Brown <neilb@suse.de>
To: "Kwolek, Adam" <adam.kwolek@intel.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"Ciechanowski, Ed" <ed.ciechanowski@intel.com>
Subject: Re: [PATCH] FIX: chunk_size cannot be read by mdstat
Date: Tue, 30 Nov 2010 18:36:18 +1100 [thread overview]
Message-ID: <20101130183618.54660849@notabene.brown> (raw)
In-Reply-To: <905EDD02F158D948B186911EB64DB3D174C8A476@irsmsx503.ger.corp.intel.com>
On Tue, 30 Nov 2010 07:28:01 +0000 "Kwolek, Adam" <adam.kwolek@intel.com>
wrote:
> In such case code:
> a->info.array.chunk_size = mdstat->chunk_size;
>
> from managemon.c, function manage_member()
> has to be removed or guarded for 0 value of mdstat->chunk_size as it corrupts information in active array.
>
Good point. I have removed that assignment, and removed the chunk_size field
from mdstat_ent.
Thanks,
NeilBrown
prev parent reply other threads:[~2010-11-30 7:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 9:56 [PATCH] FIX: chunk_size cannot be read by mdstat Adam Kwolek
2010-11-29 14:26 ` Kwolek, Adam
2010-11-30 0:22 ` Neil Brown
2010-11-30 7:28 ` Kwolek, Adam
2010-11-30 7:36 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101130183618.54660849@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).