From: Neil Brown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com
Subject: Re: [PATCH 05/10] Add spares to raid0 array using takeover
Date: Fri, 3 Dec 2010 14:52:25 +1100 [thread overview]
Message-ID: <20101203145225.2acd7436@notabene.brown> (raw)
In-Reply-To: <20101202081920.4639.78609.stgit@gklab-170-024.igk.intel.com>
On Thu, 02 Dec 2010 09:19:20 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> Spares are used by Online Capacity Expansion to expand array.
> To run expansion on raid0, spares have to be added to raid0 volume also.
> Raid0 cannot have spares (no mdmon runs for raid0 array).
> To do this, takeover to raid5 (and back) is used. mdmon runs temporary for raid5 and spare drives can be added to container.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
This is just wrong.
If mdmon is running (maybe because some other array in the container needs
it) then you add a spare to the container and send mdmon a metadata update to
apply.
If mdmon is not running, then you add a spare to the container and apply a
metadata update directly in mdadm.
There is no need to switch to raid5 and back just to add a spare.
NeilBrown
next prev parent reply other threads:[~2010-12-03 3:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 8:18 [PATCH 00/10] Pre-migration patch series Adam Kwolek
2010-12-02 8:18 ` [PATCH 01/10] FIX: Cannot exit monitor after takeover Adam Kwolek
2010-12-02 8:18 ` [PATCH 02/10] FIX: Problem with removing array " Adam Kwolek
2010-12-03 3:46 ` Neil Brown
2010-12-02 8:19 ` [PATCH 03/10] FIX: Add error code for raid_disks set Adam Kwolek
2010-12-02 18:56 ` Dan Williams
2010-12-02 8:19 ` [PATCH 04/10] Add support to skip slot configuration Adam Kwolek
2010-12-02 8:19 ` [PATCH 05/10] Add spares to raid0 array using takeover Adam Kwolek
2010-12-03 3:52 ` Neil Brown [this message]
2010-12-02 8:19 ` [PATCH 06/10] FIX: open backup file for reshape as function Adam Kwolek
2010-12-03 4:01 ` Neil Brown
2010-12-02 8:19 ` [PATCH 07/10] FIX: Do not use layout for raid4 and raid0 while geo map computing Adam Kwolek
2010-12-02 8:19 ` [PATCH 08/10] FIX: sync_completed_fd handler has to be closed Adam Kwolek
2010-12-02 8:19 ` [PATCH 09/10] FIX: Honor !reshape state on wait_reshape() entry Adam Kwolek
2010-12-03 4:11 ` Neil Brown
2010-12-02 8:19 ` [PATCH 10/10] FIX: wait_backup() sometimes hungs Adam Kwolek
2010-12-03 4:16 ` Neil Brown
2010-12-03 7:45 ` Kwolek, Adam
2010-12-03 10:35 ` Neil Brown
2010-12-03 4:19 ` [PATCH 00/10] Pre-migration patch series Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203145225.2acd7436@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).