* [PATCH] segfault in imsm create with wrong arguments
@ 2010-12-12 11:33 Luca Berra
2010-12-13 2:51 ` Neil Brown
0 siblings, 1 reply; 2+ messages in thread
From: Luca Berra @ 2010-12-12 11:33 UTC (permalink / raw)
To: linux-raid
[-- Attachment #1: Type: text/plain, Size: 202 bytes --]
When calling mdadm -C --metadata=imsm -l 1 /dev/sd..
mdadm segfaults in default_chunk_imsm()
above syntax is incorrect, but mdadm should error instead of segfaulting
--
Luca Berra -- bluca@comedia.it
[-- Attachment #2: mdadm-3.1.4-imsm-create-segfault.patch --]
[-- Type: text/plain, Size: 639 bytes --]
When calling mdadm -C --metadata=imsm -l 1 /dev/sd..
mdadm segfaults in default_chunk_imsm()
above syntax is incorrect, but mdadm should error instead of segfaulting
Signed-off-by: Luca Berra <bluca@comedia.it>
diff -p -up mdadm-3.1.4/super-intel.c.bluca mdadm-3.1.4/super-intel.c
--- mdadm-3.1.4/super-intel.c.bluca 2010-08-26 02:24:16.000000000 +0000
+++ mdadm-3.1.4/super-intel.c 2010-12-12 11:13:00.024371004 +0000
@@ -4119,7 +4119,7 @@ static int default_chunk_imsm(struct sup
{
struct intel_super *super = st->sb;
- if (!super->orom)
+ if (!super || !super->orom)
return 0;
return imsm_orom_default_chunk(super->orom);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] segfault in imsm create with wrong arguments
2010-12-12 11:33 [PATCH] segfault in imsm create with wrong arguments Luca Berra
@ 2010-12-13 2:51 ` Neil Brown
0 siblings, 0 replies; 2+ messages in thread
From: Neil Brown @ 2010-12-13 2:51 UTC (permalink / raw)
To: Luca Berra; +Cc: linux-raid
On Sun, 12 Dec 2010 12:33:55 +0100 Luca Berra <bluca@comedia.it> wrote:
> When calling mdadm -C --metadata=imsm -l 1 /dev/sd..
> mdadm segfaults in default_chunk_imsm()
> above syntax is incorrect, but mdadm should error instead of segfaulting
>
Thanks. Applied.
NeilBrown
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-13 2:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-12 11:33 [PATCH] segfault in imsm create with wrong arguments Luca Berra
2010-12-13 2:51 ` Neil Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).