From: Neil Brown <neilb@suse.de>
To: "Labun, Marcin" <Marcin.Labun@intel.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"Hawrylewicz Czarnowski,
Przemyslaw" <przemyslaw.hawrylewicz.czarnowski@intel.com>
Subject: Re: raid1 module is not ready to take IO request
Date: Thu, 16 Dec 2010 08:52:22 +1100 [thread overview]
Message-ID: <20101216085222.77efd1ef@notabene.brown> (raw)
In-Reply-To: <905EDD02F158D948B186911EB64DB3D176B3CE2F@irsmsx503.ger.corp.intel.com>
On Wed, 15 Dec 2010 17:23:56 +0000 "Labun, Marcin" <Marcin.Labun@intel.com>
wrote:
> Hi Neil,
> We have spotted that when RAID 1 array is assembled and stopped in a loop, there is an occasional kernel oops in raid1 module.
> It occurs in make_request function on wait_barrier(conf). In this case mddev->private was NULL, since probably it was not yet initialized in run() function.
> The straightforward approach is test for mdadm->private and return bio_endio with an error if private not set.
> The question is:
> Since raid1 module might receive IO request when it is not ready, what make_request can check for to test if for instance run() function has finished.
>
> Thanks,
> Marcin Labun
I cannot imagine how this would happen.
It should not be possible to call do_md_stop while there are any requests
still in flight.
Are you generating any IO between assembling the RAID1 and stopping it? If
so, how?
Can you get me the full oops message?
Thanks,
NeilBrown
next prev parent reply other threads:[~2010-12-15 21:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-15 17:23 raid1 module is not ready to take IO request Labun, Marcin
2010-12-15 21:52 ` Neil Brown [this message]
2010-12-16 10:32 ` Hawrylewicz Czarnowski, Przemyslaw
2010-12-16 11:29 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216085222.77efd1ef@notabene.brown \
--to=neilb@suse.de \
--cc=Marcin.Labun@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=przemyslaw.hawrylewicz.czarnowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).