From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 2/9] FIX: Cannot add spare to monitored container
Date: Wed, 12 Jan 2011 16:43:17 +1100 [thread overview]
Message-ID: <20110112164317.5ccfd59e@notabene.brown> (raw)
In-Reply-To: <20110111140403.13862.8338.stgit@gklab-128-013.igk.intel.com>
On Tue, 11 Jan 2011 15:04:03 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> This fix rolls backs some changes introduced by patch:
> "Add spares to raid0 in mdadm"
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
It would help a lot if you explained *why* you were rolling back these
changes.
Not applied.
NeilBrown
> ---
>
> Manage.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Manage.c b/Manage.c
> index 4e6afb5..fa1b13f 100644
> --- a/Manage.c
> +++ b/Manage.c
> @@ -800,16 +800,16 @@ int Manage_subdevs(char *devname, int fd,
> if (dv->writemostly == 1)
> disc.state |= 1 << MD_DISK_WRITEMOSTLY;
> dfd = dev_open(dv->devname, O_RDWR | O_EXCL|O_DIRECT);
> - if (tst->ss->external &&
> - mdmon_running(tst->container_dev))
> - tst->update_tail = &tst->updates;
> if (tst->ss->add_to_super(tst, &disc, dfd,
> dv->devname)) {
> close(dfd);
> return 1;
> }
> /* write_init_super will close 'dfd' */
> - if (tst->ss->write_init_super(tst))
> + if (tst->ss->external)
> + /* mdmon will write the metadata */
> + close(dfd);
> + else if (tst->ss->write_init_super(tst))
> return 1;
> } else if (dv->re_add) {
> /* this had better be raid1.
next prev parent reply other threads:[~2011-01-12 5:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 14:03 [PATCH 0/9] OLCE for external meta (cont.) Adam Kwolek
2011-01-11 14:03 ` [PATCH 1/9] imsm: FIX: set correct slot information in metadata (raid0) Adam Kwolek
2011-01-11 14:04 ` [PATCH 2/9] FIX: Cannot add spare to monitored container Adam Kwolek
2011-01-12 5:43 ` NeilBrown [this message]
2011-01-12 15:57 ` Kwolek, Adam
2011-01-13 3:07 ` NeilBrown
2011-01-13 15:15 ` Czarnowska, Anna
2011-01-11 14:04 ` [PATCH 3/9] imsm:FIX: one spare can be added to raid0 only Adam Kwolek
2011-01-12 5:44 ` NeilBrown
2011-01-12 15:15 ` Kwolek, Adam
2011-01-11 14:04 ` [PATCH 4/9] imsm: FIX: only one spare is passed in update Adam Kwolek
2011-01-12 5:46 ` NeilBrown
2011-01-11 14:04 ` [PATCH 5/9] imsm: Update metadata for second array Adam Kwolek
2011-01-12 5:48 ` NeilBrown
2011-01-11 14:04 ` [PATCH 6/9] imsm: FIX: container content gathering is not needed for size set Adam Kwolek
2011-01-12 5:52 ` NeilBrown
2011-01-12 15:30 ` Kwolek, Adam
2011-01-13 3:04 ` NeilBrown
2011-01-11 14:04 ` [PATCH 7/9] imsm: FIX: monitor should initialize 2nd reshape only Adam Kwolek
2011-01-12 5:57 ` NeilBrown
2011-01-11 14:04 ` [PATCH 8/9] FIX: container has to be frozen during reshape Adam Kwolek
2011-01-11 14:04 ` [PATCH 9/9] imsm: Proceed with second array reshape only for frozen container Adam Kwolek
2011-01-11 15:23 ` [PATCH 0/4] RAID 0 to/from RAID5 migration Labun, Marcin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112164317.5ccfd59e@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).