From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 4/9] imsm: FIX: only one spare is passed in update
Date: Wed, 12 Jan 2011 16:46:51 +1100 [thread overview]
Message-ID: <20110112164651.17b03d41@notabene.brown> (raw)
In-Reply-To: <20110111140419.13862.65110.stgit@gklab-128-013.igk.intel.com>
On Tue, 11 Jan 2011 15:04:19 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> Only one spare is passed in update.
> When more than one disk is added first spare is passed multiple times.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> super-intel.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index ef51000..321dc47 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -6448,6 +6448,7 @@ static int imsm_create_metadata_update_for_reshape(
> struct mdinfo *spares = NULL;
> int i;
> int delta_disks = 0;
> + struct mdinfo *dev;
>
> dprintf("imsm_update_metadata_for_reshape(enter) raid_disks = %i\n",
> geo->raid_disks);
> @@ -6486,15 +6487,18 @@ static int imsm_create_metadata_update_for_reshape(
> dprintf("imsm: %i spares are available.\n\n",
> spares->array.spare_disks);
>
> + dev = spares->devs;
> for (i = 0; i < delta_disks; i++) {
> - struct mdinfo *dev = spares->devs;
> struct dl *dl;
>
> + if (dev == NULL)
> + break;
> u->new_disks[i] = makedev(dev->disk.major,
> dev->disk.minor);
> dl = get_disk_super(super, dev->disk.major, dev->disk.minor);
> dl->index = mpb->num_disks;
> mpb->num_disks++;
> + dev = dev->next;
> }
>
> abort:
Applied, thanks.
NeilBrown
next prev parent reply other threads:[~2011-01-12 5:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 14:03 [PATCH 0/9] OLCE for external meta (cont.) Adam Kwolek
2011-01-11 14:03 ` [PATCH 1/9] imsm: FIX: set correct slot information in metadata (raid0) Adam Kwolek
2011-01-11 14:04 ` [PATCH 2/9] FIX: Cannot add spare to monitored container Adam Kwolek
2011-01-12 5:43 ` NeilBrown
2011-01-12 15:57 ` Kwolek, Adam
2011-01-13 3:07 ` NeilBrown
2011-01-13 15:15 ` Czarnowska, Anna
2011-01-11 14:04 ` [PATCH 3/9] imsm:FIX: one spare can be added to raid0 only Adam Kwolek
2011-01-12 5:44 ` NeilBrown
2011-01-12 15:15 ` Kwolek, Adam
2011-01-11 14:04 ` [PATCH 4/9] imsm: FIX: only one spare is passed in update Adam Kwolek
2011-01-12 5:46 ` NeilBrown [this message]
2011-01-11 14:04 ` [PATCH 5/9] imsm: Update metadata for second array Adam Kwolek
2011-01-12 5:48 ` NeilBrown
2011-01-11 14:04 ` [PATCH 6/9] imsm: FIX: container content gathering is not needed for size set Adam Kwolek
2011-01-12 5:52 ` NeilBrown
2011-01-12 15:30 ` Kwolek, Adam
2011-01-13 3:04 ` NeilBrown
2011-01-11 14:04 ` [PATCH 7/9] imsm: FIX: monitor should initialize 2nd reshape only Adam Kwolek
2011-01-12 5:57 ` NeilBrown
2011-01-11 14:04 ` [PATCH 8/9] FIX: container has to be frozen during reshape Adam Kwolek
2011-01-11 14:04 ` [PATCH 9/9] imsm: Proceed with second array reshape only for frozen container Adam Kwolek
2011-01-11 15:23 ` [PATCH 0/4] RAID 0 to/from RAID5 migration Labun, Marcin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112164651.17b03d41@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).