linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: "Labun, Marcin" <Marcin.Labun@intel.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
	"Kwolek, Adam" <adam.kwolek@intel.com>,
	"Williams, Dan J" <dan.j.williams@intel.com>,
	"Ciechanowski, Ed" <ed.ciechanowski@intel.com>,
	"Neubauer, Wojciech" <Wojciech.Neubauer@intel.com>
Subject: Re: Subject: [PATCH 3/4] Grow_reshape: need sub-array component size in data migration.
Date: Wed, 12 Jan 2011 17:16:01 +1100	[thread overview]
Message-ID: <20110112171601.14e70973@notabene.brown> (raw)
In-Reply-To: <905EDD02F158D948B186911EB64DB3D176E1A451@irsmsx503.ger.corp.intel.com>

On Tue, 11 Jan 2011 15:24:49 +0000 "Labun, Marcin" <Marcin.Labun@intel.com>
wrote:

> >From a187f2281d4053b02b1e0e3e99cdd8f406db38e3 Mon Sep 17 00:00:00 2001
> From: Marcin Labun <marcin.labun@intel.com>
> Date: Wed, 5 Jan 2011 17:38:00 +0100
> Subject: [PATCH 3/4] Grow_reshape: need sub-array component size in data migration.
> 
> Signed-off-by: Marcin Labun <marcin.labun@intel.com>
> ---
>  Grow.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Grow.c b/Grow.c
> index 1998750..9db4594 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -1406,7 +1406,7 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
>  			array.spare_disks);
>  		return 1;
>  	}
> -	sra = sysfs_read(fd, 0, GET_LEVEL | GET_DISKS | GET_DEVS | GET_STATE | GET_VERSION);
> +	sra = sysfs_read(fd, 0, GET_LEVEL | GET_DISKS | GET_DEVS | GET_STATE | GET_VERSION | GET_COMPONENT);
>  	if (sra) {
>  		if (st->ss->external && subarray == NULL) {
>  			array.level = LEVEL_CONTAINER;


I cannot see where sra->component_size is used.
Please be more explicit. (Please always be more explicit).

NeilBrown


      reply	other threads:[~2011-01-12  6:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-11 15:24 Subject: [PATCH 3/4] Grow_reshape: need sub-array component size in data migration Labun, Marcin
2011-01-12  6:16 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110112171601.14e70973@notabene.brown \
    --to=neilb@suse.de \
    --cc=Marcin.Labun@intel.com \
    --cc=Wojciech.Neubauer@intel.com \
    --cc=adam.kwolek@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ed.ciechanowski@intel.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).