* Subject: [PATCH 3/4] Grow_reshape: need sub-array component size in data migration.
@ 2011-01-11 15:24 Labun, Marcin
2011-01-12 6:16 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Labun, Marcin @ 2011-01-11 15:24 UTC (permalink / raw)
To: neilb@suse.de
Cc: linux-raid@vger.kernel.org, Kwolek, Adam, Williams, Dan J,
Ciechanowski, Ed, Neubauer, Wojciech
From a187f2281d4053b02b1e0e3e99cdd8f406db38e3 Mon Sep 17 00:00:00 2001
From: Marcin Labun <marcin.labun@intel.com>
Date: Wed, 5 Jan 2011 17:38:00 +0100
Subject: [PATCH 3/4] Grow_reshape: need sub-array component size in data migration.
Signed-off-by: Marcin Labun <marcin.labun@intel.com>
---
Grow.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Grow.c b/Grow.c
index 1998750..9db4594 100644
--- a/Grow.c
+++ b/Grow.c
@@ -1406,7 +1406,7 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
array.spare_disks);
return 1;
}
- sra = sysfs_read(fd, 0, GET_LEVEL | GET_DISKS | GET_DEVS | GET_STATE | GET_VERSION);
+ sra = sysfs_read(fd, 0, GET_LEVEL | GET_DISKS | GET_DEVS | GET_STATE | GET_VERSION | GET_COMPONENT);
if (sra) {
if (st->ss->external && subarray == NULL) {
array.level = LEVEL_CONTAINER;
--
1.6.4.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Subject: [PATCH 3/4] Grow_reshape: need sub-array component size in data migration.
2011-01-11 15:24 Subject: [PATCH 3/4] Grow_reshape: need sub-array component size in data migration Labun, Marcin
@ 2011-01-12 6:16 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2011-01-12 6:16 UTC (permalink / raw)
To: Labun, Marcin
Cc: linux-raid@vger.kernel.org, Kwolek, Adam, Williams, Dan J,
Ciechanowski, Ed, Neubauer, Wojciech
On Tue, 11 Jan 2011 15:24:49 +0000 "Labun, Marcin" <Marcin.Labun@intel.com>
wrote:
> >From a187f2281d4053b02b1e0e3e99cdd8f406db38e3 Mon Sep 17 00:00:00 2001
> From: Marcin Labun <marcin.labun@intel.com>
> Date: Wed, 5 Jan 2011 17:38:00 +0100
> Subject: [PATCH 3/4] Grow_reshape: need sub-array component size in data migration.
>
> Signed-off-by: Marcin Labun <marcin.labun@intel.com>
> ---
> Grow.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index 1998750..9db4594 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -1406,7 +1406,7 @@ int Grow_reshape(char *devname, int fd, int quiet, char *backup_file,
> array.spare_disks);
> return 1;
> }
> - sra = sysfs_read(fd, 0, GET_LEVEL | GET_DISKS | GET_DEVS | GET_STATE | GET_VERSION);
> + sra = sysfs_read(fd, 0, GET_LEVEL | GET_DISKS | GET_DEVS | GET_STATE | GET_VERSION | GET_COMPONENT);
> if (sra) {
> if (st->ss->external && subarray == NULL) {
> array.level = LEVEL_CONTAINER;
I cannot see where sra->component_size is used.
Please be more explicit. (Please always be more explicit).
NeilBrown
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-12 6:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-11 15:24 Subject: [PATCH 3/4] Grow_reshape: need sub-array component size in data migration Labun, Marcin
2011-01-12 6:16 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).