From: NeilBrown <neilb@suse.de>
To: "Kwolek, Adam" <adam.kwolek@intel.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"Ciechanowski, Ed" <ed.ciechanowski@intel.com>,
"Neubauer, Wojciech" <Wojciech.Neubauer@intel.com>
Subject: Re: [PATCH 02/13] imsm: FIX: allow for container reshape any unset size value
Date: Wed, 12 Jan 2011 21:43:36 +1100 [thread overview]
Message-ID: <20110112214336.303679ac@notabene.brown> (raw)
In-Reply-To: <905EDD02F158D948B186911EB64DB3D176E1A820@irsmsx503.ger.corp.intel.com>
On Wed, 12 Jan 2011 08:32:10 +0000 "Kwolek, Adam" <adam.kwolek@intel.com>
wrote:
> This issue can be addressed in the following way:
>
> >From ce0a720c162c425ae46684ac7866f7076e65d5e5 Mon Sep 17 00:00:00 2001
> From: Adam Kwolek <adam.kwolek@intel.com>
> Date: Wed, 12 Jan 2011 09:23:53 +0100
> Subject: [PATCH] FIX: size is passed incorrectly
>
> reshape_super() called from reshape_container() with size set to info->component_size
> gives size in reshape_super == -2 due to unsigned signed conversion
> (info->component_size is not initializes).
>
> As size is not changed during container reshape '-1' value is passed to indicate this.
Excellent problem description that allows me to immediately see the that the
solution is obviously correct.
Thanks. Applied and pushed out.
NeilBrown
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
> Grow.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index 4cbe427..466d546 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -2120,7 +2120,7 @@ int reshape_container(char *container, int cfd, char *devname,
> {
> struct mdinfo *cc = NULL;
>
> - if (reshape_super(st, info->component_size, info->new_level,
> + if (reshape_super(st, -1, info->new_level,
> info->new_layout, info->new_chunk,
> info->array.raid_disks + info->delta_disks,
> backup_file, devname, quiet))
next prev parent reply other threads:[~2011-01-12 10:43 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-10 11:27 [PATCH 00/13] OLCE for external meta Raid5/single array Adam Kwolek
2011-01-10 11:27 ` [PATCH 01/13] Manage reshape process in manage_reshape vector Adam Kwolek
2011-01-12 3:51 ` NeilBrown
2011-01-10 11:27 ` [PATCH 02/13] imsm: FIX: allow for container reshape any unset size value Adam Kwolek
2011-01-12 3:52 ` NeilBrown
2011-01-12 8:32 ` Kwolek, Adam
2011-01-12 10:43 ` NeilBrown [this message]
2011-01-10 11:27 ` [PATCH 03/13] imsm: FIX: when monitor is active post update Adam Kwolek
2011-01-12 3:56 ` NeilBrown
2011-01-10 11:27 ` [PATCH 04/13] FIX: load anchor to get all information Adam Kwolek
2011-01-12 3:58 ` NeilBrown
2011-01-10 11:28 ` [PATCH 05/13] msm: FIX: when mdadm reloads anchor not need for local modyfication Adam Kwolek
2011-01-10 11:28 ` [PATCH 06/13] imsm: FIX: update disks status in container_contents() Adam Kwolek
2011-01-12 4:14 ` NeilBrown
2011-01-10 11:28 ` [PATCH 07/13] FIX: wrong flags are passed to function Adam Kwolek
2011-01-10 11:28 ` [PATCH 08/13] FIX/WORKAROUND: added disks are not used by reshape process /md/ Adam Kwolek
2011-01-12 4:39 ` NeilBrown
2011-01-10 11:28 ` [PATCH 09/13] Finalize reshape after adding disks to array Adam Kwolek
2011-01-12 4:52 ` NeilBrown
2011-01-10 11:28 ` [PATCH 10/13] FIX: Cannot unmount array after reshape Adam Kwolek
2011-01-12 4:53 ` NeilBrown
2011-01-12 15:12 ` Kwolek, Adam
2011-01-10 11:28 ` [PATCH 11/13] FIX/WORKAROUND: Arrays cannot be opened exclusively Adam Kwolek
2011-01-10 11:29 ` [PATCH 12/13] FIX: parity disks use for redundant levels only Adam Kwolek
2011-01-12 4:59 ` NeilBrown
2011-01-10 11:29 ` [PATCH 13/13] FIX: Fill sys_name for disk add Adam Kwolek
2011-01-12 5:02 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110112214336.303679ac@notabene.brown \
--to=neilb@suse.de \
--cc=Wojciech.Neubauer@intel.com \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).