From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 3/8] imsm: FIX: local mdadm update shouldn't be done in update creation function.
Date: Thu, 13 Jan 2011 13:41:21 +1100 [thread overview]
Message-ID: <20110113134121.00b23fec@notabene.brown> (raw)
In-Reply-To: <20110112135442.15045.61099.stgit@gklab-128-013.igk.intel.com>
On Wed, 12 Jan 2011 14:54:42 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> Local update is performed based on created update, so this code can broke
> local update and it is not necessary as prepare and process update functions
> are used.
>
> Code removed.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> super-intel.c | 13 -------------
> 1 files changed, 0 insertions(+), 13 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 7038433..de41702 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -6492,19 +6492,6 @@ static int imsm_create_metadata_update_for_reshape(
> mpb->num_disks++;
> dev = dev->next;
> }
> - /* Now update the metadata so that container_content will find
> - * the new devices
> - */
> - for (i = 0; i < mpb->num_raid_devs; i++) {
> - int d;
> - struct imsm_dev *dev = get_imsm_dev(super, i);
> - struct imsm_map *map = get_imsm_map(dev, 0);
> - map->num_members = geo->raid_disks;
> - for (d = 0; d < delta_disks; d++) {
> - set_imsm_ord_tbl_ent(map, old_raid_disks + d,
> - mpb->num_disks - delta_disks + d);
> - }
> - }
>
> abort:
> /* free spares
Applied, thanks.
NeilBrown
next prev parent reply other threads:[~2011-01-13 2:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 13:54 [PATCH 0/8] OLCE Raid5/0 single array for external meta Adam Kwolek
2011-01-12 13:54 ` [PATCH 1/8] FIX: put update in to queue for local meta update Adam Kwolek
2011-01-12 13:54 ` [PATCH 2/8] imsm: FIX: mdadm should process local data Adam Kwolek
2011-01-13 2:41 ` NeilBrown
2011-01-12 13:54 ` [PATCH 3/8] imsm: FIX: local mdadm update shouldn't be done in update creation function Adam Kwolek
2011-01-13 2:41 ` NeilBrown [this message]
2011-01-12 13:54 ` [PATCH 4/8] imsm: FIX: old devices memory has to be released Adam Kwolek
2011-01-13 2:41 ` NeilBrown
2011-01-12 13:55 ` [PATCH 5/8] FIX: Cannot load container information Adam Kwolek
2011-01-13 2:42 ` NeilBrown
2011-01-12 13:55 ` [PATCH 6/8] imsm: FIX: spares are not counted Adam Kwolek
2011-01-13 2:42 ` NeilBrown
2011-01-12 13:55 ` [PATCH 7/8] Finalize reshape after adding disks to array Adam Kwolek
2011-01-13 2:43 ` NeilBrown
2011-01-13 9:25 ` Kwolek, Adam
2011-01-12 13:55 ` [PATCH 8/8] FIX: reload metadata for container operation Adam Kwolek
2011-01-13 2:44 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113134121.00b23fec@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).