From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 6/8] imsm: FIX: spares are not counted
Date: Thu, 13 Jan 2011 13:42:30 +1100 [thread overview]
Message-ID: <20110113134230.613fbe94@notabene.brown> (raw)
In-Reply-To: <20110112135510.15045.78096.stgit@gklab-128-013.igk.intel.com>
On Wed, 12 Jan 2011 14:55:10 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> Field info->array.spare_disks is used on begin of reshape_array() to check
> if there is enough number of spares to process reshape.
> During container_content_imsm() call spare disks are not counted.
> This causes that reshape_array() reports that there is not enough spares
> to execute reshape.
>
> Patch adds spares counting for reshape process.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> super-intel.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index c3ff365..0c70fda 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -4632,9 +4632,13 @@ static struct mdinfo *container_content_imsm(struct supertype *st, char *subarra
> if (map2) {
> if (slot < map2->num_members)
> info_d->disk.state = (1 << MD_DISK_ACTIVE);
> + else
> + this->array.spare_disks++;
> } else {
> if (slot < map->num_members)
> info_d->disk.state = (1 << MD_DISK_ACTIVE);
> + else
> + this->array.spare_disks++;
> }
> if (info_d->recovery_start == MaxSector)
> this->array.working_disks++;
Applied, thanks.
NeilBrown
next prev parent reply other threads:[~2011-01-13 2:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 13:54 [PATCH 0/8] OLCE Raid5/0 single array for external meta Adam Kwolek
2011-01-12 13:54 ` [PATCH 1/8] FIX: put update in to queue for local meta update Adam Kwolek
2011-01-12 13:54 ` [PATCH 2/8] imsm: FIX: mdadm should process local data Adam Kwolek
2011-01-13 2:41 ` NeilBrown
2011-01-12 13:54 ` [PATCH 3/8] imsm: FIX: local mdadm update shouldn't be done in update creation function Adam Kwolek
2011-01-13 2:41 ` NeilBrown
2011-01-12 13:54 ` [PATCH 4/8] imsm: FIX: old devices memory has to be released Adam Kwolek
2011-01-13 2:41 ` NeilBrown
2011-01-12 13:55 ` [PATCH 5/8] FIX: Cannot load container information Adam Kwolek
2011-01-13 2:42 ` NeilBrown
2011-01-12 13:55 ` [PATCH 6/8] imsm: FIX: spares are not counted Adam Kwolek
2011-01-13 2:42 ` NeilBrown [this message]
2011-01-12 13:55 ` [PATCH 7/8] Finalize reshape after adding disks to array Adam Kwolek
2011-01-13 2:43 ` NeilBrown
2011-01-13 9:25 ` Kwolek, Adam
2011-01-12 13:55 ` [PATCH 8/8] FIX: reload metadata for container operation Adam Kwolek
2011-01-13 2:44 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113134230.613fbe94@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).