From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 7/8] Finalize reshape after adding disks to array
Date: Thu, 13 Jan 2011 13:43:17 +1100 [thread overview]
Message-ID: <20110113134317.173c0b26@notabene.brown> (raw)
In-Reply-To: <20110112135518.15045.88138.stgit@gklab-128-013.igk.intel.com>
On Wed, 12 Jan 2011 14:55:18 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> When reshape is finished, monitor has to finalize reshape in metadata for curent array.
> To do this set_array_state() should be called.
> This finishes migration and stores metadata on disks.
>
> This finishes reshape flow in mdmon.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> monitor.c | 11 +++++++++++
> 1 files changed, 11 insertions(+), 0 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index 1107d47..a0068d3 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -322,6 +322,17 @@ static int read_and_act(struct active_array *a)
> */
> check_reshape = 1;
>
> + /* finalize reshape detection
> + */
> + if ((a->curr_action != reshape) &&
> + (a->prev_action == reshape)) {
> + /* A reshape has finished.
> + * Some disks may be in sync now.
> + */
> + a->container->ss->set_array_state(a, a->curr_state <= clean);
> + check_degraded = 1;
> + }
> +
> /* Check for failures and if found:
> * 1/ Record the failure in the metadata and unblock the device.
> * FIXME update the kernel to stop notifying on failed drives when
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
One day you will explain to me why the current code isn't sufficient like I
keep asking you do. Then maybe I'll apply this patch.
Until then, I won't.
NeilBrown
next prev parent reply other threads:[~2011-01-13 2:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-12 13:54 [PATCH 0/8] OLCE Raid5/0 single array for external meta Adam Kwolek
2011-01-12 13:54 ` [PATCH 1/8] FIX: put update in to queue for local meta update Adam Kwolek
2011-01-12 13:54 ` [PATCH 2/8] imsm: FIX: mdadm should process local data Adam Kwolek
2011-01-13 2:41 ` NeilBrown
2011-01-12 13:54 ` [PATCH 3/8] imsm: FIX: local mdadm update shouldn't be done in update creation function Adam Kwolek
2011-01-13 2:41 ` NeilBrown
2011-01-12 13:54 ` [PATCH 4/8] imsm: FIX: old devices memory has to be released Adam Kwolek
2011-01-13 2:41 ` NeilBrown
2011-01-12 13:55 ` [PATCH 5/8] FIX: Cannot load container information Adam Kwolek
2011-01-13 2:42 ` NeilBrown
2011-01-12 13:55 ` [PATCH 6/8] imsm: FIX: spares are not counted Adam Kwolek
2011-01-13 2:42 ` NeilBrown
2011-01-12 13:55 ` [PATCH 7/8] Finalize reshape after adding disks to array Adam Kwolek
2011-01-13 2:43 ` NeilBrown [this message]
2011-01-13 9:25 ` Kwolek, Adam
2011-01-12 13:55 ` [PATCH 8/8] FIX: reload metadata for container operation Adam Kwolek
2011-01-13 2:44 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113134317.173c0b26@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).