From: NeilBrown <neilb@suse.de>
To: "Czarnowska, Anna" <anna.czarnowska@intel.com>
Cc: "linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"Ciechanowski, Ed" <ed.ciechanowski@intel.com>,
"Hawrylewicz Czarnowski,
Przemyslaw" <przemyslaw.hawrylewicz.czarnowski@intel.com>,
"Labun, Marcin" <Marcin.Labun@intel.com>,
"Neubauer, Wojciech" <Wojciech.Neubauer@intel.com>
Subject: Re: [PATCH] fix: Monitor: min_size must be set to 0
Date: Mon, 17 Jan 2011 12:46:28 +1100 [thread overview]
Message-ID: <20110117124628.30c8bd5e@notabene.brown> (raw)
In-Reply-To: <A9DE54D0CD747C4CB06DCE5B6FA2246F010E8FDFF2@irsmsx504.ger.corp.intel.com>
On Thu, 13 Jan 2011 15:03:14 +0000 "Czarnowska, Anna"
<anna.czarnowska@intel.com> wrote:
> >From ac2d3550f2bd4fafb6497b881cac3c02d147c21a Mon Sep 17 00:00:00 2001
> From: Anna Czarnowska <anna.czarnowska@intel.com>
> Date: Thu, 13 Jan 2011 15:58:39 +0100
> Subject: [PATCH] fix: Monitor: min_size must be set to 0
>
> Otherwise a random value will be used for comparison later
> for native and ddf metadata (until min_acceptable_spare_size is defined).
>
> Signed-off-by: Anna Czarnowska <anna.czarnowska@intel.com>
> ---
> Monitor.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/Monitor.c b/Monitor.c
> index ab1ae26..9e2a478 100644
> --- a/Monitor.c
> +++ b/Monitor.c
> @@ -707,8 +707,10 @@ static int get_min_spare_size_required(struct state *st, unsigned long long *siz
> int fd;
>
> if (!st->metadata ||
> - !st->metadata->ss->min_acceptable_spare_size)
> + !st->metadata->ss->min_acceptable_spare_size) {
> + *sizep = 0;
> return 0;
> + }
>
> fd = open(st->devname, O_RDONLY);
> if (fd < 0)
Applied, thanks.
NeilBrown
prev parent reply other threads:[~2011-01-17 1:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 15:03 [PATCH] fix: Monitor: min_size must be set to 0 Czarnowska, Anna
2011-01-17 1:46 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117124628.30c8bd5e@notabene.brown \
--to=neilb@suse.de \
--cc=Marcin.Labun@intel.com \
--cc=Wojciech.Neubauer@intel.com \
--cc=anna.czarnowska@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=przemyslaw.hawrylewicz.czarnowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).