From: NeilBrown <neilb@suse.de>
To: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
Cc: linux-raid@vger.kernel.org, wojciech.neubauer@intel.com,
adam.kwolek@intel.com, dan.j.williams@intel.com,
ed.ciechanowski@intel.com
Subject: Re: [PATCH 2/6] Set reshape.after.data_disks for raid0<->raid10 takeover
Date: Mon, 17 Jan 2011 13:03:05 +1100 [thread overview]
Message-ID: <20110117130305.1f998863@notabene.brown> (raw)
In-Reply-To: <20110113153235.20266.84653.stgit@gklab-128-111.igk.intel.com>
On Thu, 13 Jan 2011 16:32:35 +0100 Krzysztof Wojcik
<krzysztof.wojcik@intel.com> wrote:
> reshape.after.data_disks field must be initiated
> for raid0<->rai10 transition.
> Instead calculated spares_needed variable in reshape_array
> function has random value.
>
> Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
> ---
> Grow.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index 763287b..47a8fb8 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -966,6 +966,7 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
> re->level = 0;
> re->parity = 0;
> re->before.data_disks = new_disks;
> + re->after.data_disks = re->before.data_disks;
> re->before.layout = 0;
> re->backup_blocks = 0;
> return NULL;
> @@ -1003,6 +1004,7 @@ char *analyse_change(struct mdinfo *info, struct reshape *re)
> re->parity = 0;
> re->before.data_disks = (info->array.raid_disks +
> info->delta_disks);
> + re->after.data_disks = re->before.data_disks;
> re->before.layout = info->new_layout;
> re->backup_blocks = 0;
> return NULL;
apply, thanks.
NeilBrown
next prev parent reply other threads:[~2011-01-17 2:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 15:32 [PATCH 0/6] Add raid0<->raid10 takeover support for imsm metadata Krzysztof Wojcik
2011-01-13 15:32 ` [PATCH 1/6] Define imsm_analyze_change function Krzysztof Wojcik
2011-01-17 2:02 ` NeilBrown
2011-01-13 15:32 ` [PATCH 2/6] Set reshape.after.data_disks for raid0<->raid10 takeover Krzysztof Wojcik
2011-01-17 2:03 ` NeilBrown [this message]
2011-01-13 15:32 ` [PATCH 3/6] Unfreeze for non re-striping transitions Krzysztof Wojcik
2011-01-17 2:04 ` NeilBrown
2011-01-13 15:32 ` [PATCH 4/6] Add raid10 -> raid0 takeover support Krzysztof Wojcik
2011-01-17 2:06 ` NeilBrown
2011-01-13 15:33 ` [PATCH 5/6] raid0->raid10 takeover- create metadata update Krzysztof Wojcik
2011-01-13 15:33 ` [PATCH 6/6] raid0->raid10 takeover- allocate memory for added disks Krzysztof Wojcik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117130305.1f998863@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=krzysztof.wojcik@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).