Re: [PATCH] FIX: reshape_active flag is always set for external metadata

[NeilBrown <neilb@suse.de>]

On Thu, 20 Jan 2011 16:52:31 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:

> For external metadata based on reshape_active flag is taken decision about reshape
> when it is equal to 1. At this momenta mdadm cannot give up when this flag is set
> for external metadata.
> 
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
> 
>  Grow.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Grow.c b/Grow.c
> index c9f4b9c..f220f50 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -1870,7 +1870,7 @@ started:
>  
>  	sra->new_chunk = info->new_chunk;
>  	
> -	if (info->reshape_active)
> +	if ((info->reshape_active) && (st->ss->external == 0))
>  		/* nothing needed here */;
>  	else if (info->array.chunk_size == info->new_chunk &&
>  	    reshape.before.layout == reshape.after.layout &&
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

I can guess why you think you need this, though it is always better to say
explicitly what the problem is that you are fixing.

But this is the wrong place for the fix.

I assume this is when you are assembling an array that is in the middle of a
reshape.  For that case, sysfs_set_array (called from set_array_info called
from Assemble) is the place to configure the 'new' geometry of the array.

NeilBrown