From: Neil Brown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH] FIX: reshape_active flag is always set for external metadata
Date: Thu, 27 Jan 2011 13:07:17 +1000 [thread overview]
Message-ID: <20110127130717.5da65455@nbeee.brown> (raw)
In-Reply-To: <20110120155231.9026.34311.stgit@gklab-128-013.igk.intel.com>
On Thu, 20 Jan 2011 16:52:31 +0100
Adam Kwolek <adam.kwolek@intel.com> wrote:
> For external metadata based on reshape_active flag is taken decision
> about reshape when it is equal to 1. At this momenta mdadm cannot
> give up when this flag is set for external metadata.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> Grow.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index c9f4b9c..f220f50 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -1870,7 +1870,7 @@ started:
>
> sra->new_chunk = info->new_chunk;
>
> - if (info->reshape_active)
> + if ((info->reshape_active) && (st->ss->external == 0))
This is a bit too simplistic. I have applied a patch which is
(hopefully) more thorough.
Thanks,
NeilBrown
> /* nothing needed here */;
> else if (info->array.chunk_size == info->new_chunk &&
> reshape.before.layout == reshape.after.layout &&
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid"
> in the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-01-27 3:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-20 15:52 [PATCH] FIX: reshape_active flag is always set for external metadata Adam Kwolek
2011-01-24 21:05 ` NeilBrown
2011-01-25 7:27 ` Kwolek, Adam
2011-01-27 3:07 ` Neil Brown [this message]
2011-01-27 7:56 ` Kwolek, Adam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110127130717.5da65455@nbeee.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).