From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Brown Subject: Re: [PATCH] FIX: reshape_active flag is always set for external metadata Date: Thu, 27 Jan 2011 13:07:17 +1000 Message-ID: <20110127130717.5da65455@nbeee.brown> References: <20110120155231.9026.34311.stgit@gklab-128-013.igk.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110120155231.9026.34311.stgit@gklab-128-013.igk.intel.com> Sender: linux-raid-owner@vger.kernel.org To: Adam Kwolek Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com, ed.ciechanowski@intel.com, wojciech.neubauer@intel.com List-Id: linux-raid.ids On Thu, 20 Jan 2011 16:52:31 +0100 Adam Kwolek wrote: > For external metadata based on reshape_active flag is taken decision > about reshape when it is equal to 1. At this momenta mdadm cannot > give up when this flag is set for external metadata. > > Signed-off-by: Adam Kwolek > --- > > Grow.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/Grow.c b/Grow.c > index c9f4b9c..f220f50 100644 > --- a/Grow.c > +++ b/Grow.c > @@ -1870,7 +1870,7 @@ started: > > sra->new_chunk = info->new_chunk; > > - if (info->reshape_active) > + if ((info->reshape_active) && (st->ss->external == 0)) This is a bit too simplistic. I have applied a patch which is (hopefully) more thorough. Thanks, NeilBrown > /* nothing needed here */; > else if (info->array.chunk_size == info->new_chunk && > reshape.before.layout == reshape.after.layout && > > -- > To unsubscribe from this list: send the line "unsubscribe linux-raid" > in the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html