From: Neil Brown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 7/7] FIX: start_reshape status should be checked
Date: Fri, 28 Jan 2011 10:41:06 +1000 [thread overview]
Message-ID: <20110128104106.20bf7a6f@nbeee.brown> (raw)
In-Reply-To: <20110126150406.20454.70549.stgit@gklab-128-013.igk.intel.com>
On Wed, 26 Jan 2011 16:04:06 +0100
Adam Kwolek <adam.kwolek@intel.com> wrote:
> mdadm should verify if reshape is started before it goes
> in to check-pointing machine.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> Grow.c | 7 ++++++-
> 1 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index dae1b32..a60129a 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -1934,7 +1934,12 @@ started:
> }
> }
>
> - start_reshape(sra);
> + err = start_reshape(sra);
> + if (err) {
> + fprintf(stderr, Name ": Cannot start reshape for
> %s\n",
> + devname);
> + goto release;
> + }
> if (restart)
> sysfs_set_str(sra, NULL, "array_state", "active");
>
Applied, thanks.
NeilBrown
prev parent reply other threads:[~2011-01-28 0:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-26 15:03 [PATCH 0/7] Online Capacity Expansion (raid5/0, all arrays in container, rebased) Adam Kwolek
2011-01-26 15:03 ` [PATCH 1/7] imsm: Update metadata for second array Adam Kwolek
2011-01-28 0:24 ` Neil Brown
2011-01-28 8:11 ` Kwolek, Adam
2011-01-26 15:03 ` [PATCH 2/7] FIX: monitor doesn't handshake with md Adam Kwolek
2011-01-26 15:03 ` [PATCH 3/7] imsm: FIX: do not allow for container operation for the same disks number Adam Kwolek
2011-01-28 0:25 ` Neil Brown
2011-01-26 15:03 ` [PATCH 4/7] FIX: Array after takeover has to be frozen Adam Kwolek
2011-01-28 0:40 ` Neil Brown
2011-01-28 8:16 ` Kwolek, Adam
2011-01-26 15:03 ` [PATCH 5/7] imsm: FIX: spare cannot be added Adam Kwolek
2011-01-26 15:03 ` [PATCH 6/7] FIX: Container can be left frozen Adam Kwolek
2011-01-26 15:04 ` [PATCH 7/7] FIX: start_reshape status should be checked Adam Kwolek
2011-01-28 0:41 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110128104106.20bf7a6f@nbeee.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).