From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Brown Subject: Re: [PATCH 7/7] FIX: start_reshape status should be checked Date: Fri, 28 Jan 2011 10:41:06 +1000 Message-ID: <20110128104106.20bf7a6f@nbeee.brown> References: <20110126145632.20454.20432.stgit@gklab-128-013.igk.intel.com> <20110126150406.20454.70549.stgit@gklab-128-013.igk.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110126150406.20454.70549.stgit@gklab-128-013.igk.intel.com> Sender: linux-raid-owner@vger.kernel.org To: Adam Kwolek Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com, ed.ciechanowski@intel.com, wojciech.neubauer@intel.com List-Id: linux-raid.ids On Wed, 26 Jan 2011 16:04:06 +0100 Adam Kwolek wrote: > mdadm should verify if reshape is started before it goes > in to check-pointing machine. > > Signed-off-by: Adam Kwolek > --- > > Grow.c | 7 ++++++- > 1 files changed, 6 insertions(+), 1 deletions(-) > > diff --git a/Grow.c b/Grow.c > index dae1b32..a60129a 100644 > --- a/Grow.c > +++ b/Grow.c > @@ -1934,7 +1934,12 @@ started: > } > } > > - start_reshape(sra); > + err = start_reshape(sra); > + if (err) { > + fprintf(stderr, Name ": Cannot start reshape for > %s\n", > + devname); > + goto release; > + } > if (restart) > sysfs_set_str(sra, NULL, "array_state", "active"); > Applied, thanks. NeilBrown