From mboxrd@z Thu Jan 1 00:00:00 1970 From: NeilBrown Subject: Re: [PATCH] imsm: FIX: not all disks are released in free_imsm_disks() Date: Mon, 31 Jan 2011 11:07:13 +1100 Message-ID: <20110131110713.734364db@notabene.brown> References: <20110128133750.16213.62160.stgit@gklab-128-013.igk.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110128133750.16213.62160.stgit@gklab-128-013.igk.intel.com> Sender: linux-raid-owner@vger.kernel.org To: Adam Kwolek Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com, ed.ciechanowski@intel.com, wojciech.neubauer@intel.com List-Id: linux-raid.ids On Fri, 28 Jan 2011 14:37:51 +0100 Adam Kwolek wrote: > Adding spare disks to imsm container fails due to problem with writing > new_dev to sysfs. This problem was caused by not closed handle > (opened exclusively) in Manage.c:803. > > Disk handle was not closed by free_imsm(). > This is due to not released disk_mgmt_list in free_imsm_disks(). > > Proper release of imsm metadata allows for spare adding without problems. > Memory leak was fixed also. > > Signed-off-by: Adam Kwolek > --- > > super-intel.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/super-intel.c b/super-intel.c > index 958a02b..8bb21dd 100644 > --- a/super-intel.c > +++ b/super-intel.c > @@ -2687,6 +2687,11 @@ static void free_imsm_disks(struct intel_super *super) > super->disks = d->next; > __free_imsm_disk(d); > } > + while (super->disk_mgmt_list) { > + d = super->disk_mgmt_list; > + super->disk_mgmt_list = d->next; > + __free_imsm_disk(d); > + } > while (super->missing) { > d = super->missing; > super->missing = d->next; Applied, thanks. NeilBrown