From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 0/2] patches addresses problem with memory corruption
Date: Tue, 1 Feb 2011 10:38:02 +1100 [thread overview]
Message-ID: <20110201103802.6513b66a@notabene.brown> (raw)
In-Reply-To: <20110131151657.13213.16328.stgit@gklab-128-013.igk.intel.com>
On Mon, 31 Jan 2011 16:25:08 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> When for raid0 metadata is updated outside mdmon it can happen that
> memory corruption occurs due to too amount of memory is allocated
> for imsm device structure.
>
> 1. imsm: FIX: mdmon crash during 2 raid0 arrays expansion
> this patch is almost the same to sent earlier except 2 changes:
> a) compilation problem
> b) size should affect anchor size also
> (added calculation changes extends space_needed variable also
> this variable is used for anchor allocation)
> so it replaces previous one.
> 2. imsm: FIX: sizeof_imsm_dev() can return too small value
> size returned by sizeof_imsm_dev() describes minimum size of device
> This is correct when both device maps has the same length
> When device expands or shrinks we should return size that allows
> for storing larger device information to avoid memory corruption.
>
Both applied (replacing the previous one)..
Thanks.
NeilBrown
> BR
> Adam
>
> ---
>
> Adam Kwolek (2):
> imsm: FIX: sizeof_imsm_dev() can return too small value
> imsm: FIX: mdmon crash during 2 raid0 arrays expansion
>
>
> super-intel.c | 20 +++++++++++++++-----
> 1 files changed, 15 insertions(+), 5 deletions(-)
>
prev parent reply other threads:[~2011-01-31 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 15:25 [PATCH 0/2] patches addresses problem with memory corruption Adam Kwolek
2011-01-31 15:25 ` [PATCH 1/2] imsm: FIX: mdmon crash during 2 raid0 arrays expansion Adam Kwolek
2011-01-31 15:25 ` [PATCH 2/2] imsm: FIX: sizeof_imsm_dev() can return too small value Adam Kwolek
2011-01-31 15:59 ` [PATCH 0/2] patches addresses problem with memory corruption Kwolek, Adam
2011-01-31 23:49 ` NeilBrown
2011-01-31 23:38 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110201103802.6513b66a@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).