From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH] imsm: FIX: size have to be calculated based on first map
Date: Thu, 3 Feb 2011 18:26:11 +1100 [thread overview]
Message-ID: <20110203182611.41a737a6@notabene.brown> (raw)
In-Reply-To: <20110201142454.16252.58382.stgit@gklab-128-013.igk.intel.com>
On Tue, 01 Feb 2011 15:24:54 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> Before reshape finalization migration is still present in metadata.
> After patch 'imsm: FIX: crash during getting map'
> function get_imsm_map() returns correct value,
> this means in our case from second (start) map.
>
> We should calculate map size basing on first (final) map.
> For this we should request it by setting second function parameter to '0'
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> super-intel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index c70d44b..4565d80 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -5188,7 +5188,7 @@ static int imsm_set_array_state(struct active_array *a, int consistent)
> int used_disks;
> struct mdinfo *mdi;
>
> - used_disks = imsm_num_data_members(dev, -1);
> + used_disks = imsm_num_data_members(dev, 0);
> if (used_disks > 0) {
> array_blocks =
> map->blocks_per_member *
Applied, thanks.
NeilBrown
prev parent reply other threads:[~2011-02-03 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 14:24 [PATCH] imsm: FIX: size have to be calculated based on first map Adam Kwolek
2011-02-03 7:26 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110203182611.41a737a6@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).