From: NeilBrown <neilb@suse.de>
To: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
Cc: linux-raid@vger.kernel.org, wojciech.neubauer@intel.com,
adam.kwolek@intel.com, dan.j.williams@intel.com,
ed.ciechanowski@intel.com
Subject: Re: [PATCH 0/2] FIX: Process hangs at wait_barrier
Date: Tue, 8 Feb 2011 11:50:30 +1100 [thread overview]
Message-ID: <20110208115030.3cc6b2f0@notabene.brown> (raw)
In-Reply-To: <20110204130757.6426.81544.stgit@gklab-128-111.igk.intel.com>
On Fri, 04 Feb 2011 14:18:18 +0100 Krzysztof Wojcik
<krzysztof.wojcik@intel.com> wrote:
> Patches resolve problem with process crash at wait_barrier()
> after raid0->raid10 takeover.
> First patch resolve this particular problem.
> Solution is similar to RAID1 barrier implementation.
> Second is proposal for general protection against barrier
> become negative.
>
> ---
>
> Krzysztof Wojcik (2):
> FIX: md: process hangs at wait_barrier after 0->10 takeover
Applied, thanks.
> FIX: md: Prevent barrier become negative
If we ever trying to make 'barrier' negative, that is a bug somewhere.
So I would prefer:
BUG_ON(conf->barrier <= 0);
conf->barrier--;
NeilBrown
>
>
> drivers/md/raid1.c | 3 ++-
> drivers/md/raid10.c | 9 ++++++---
> 2 files changed, 8 insertions(+), 4 deletions(-)
>
prev parent reply other threads:[~2011-02-08 0:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-04 13:18 [PATCH 0/2] FIX: Process hangs at wait_barrier Krzysztof Wojcik
2011-02-04 13:18 ` [PATCH 1/2] FIX: md: process hangs at wait_barrier after 0->10 takeover Krzysztof Wojcik
2011-02-04 13:18 ` [PATCH 2/2] FIX: md: Prevent barrier become negative Krzysztof Wojcik
2011-02-08 0:50 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208115030.3cc6b2f0@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=krzysztof.wojcik@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).