From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH] UT FIX: Pass all UT in suit 13
Date: Wed, 9 Feb 2011 20:52:03 +1100 [thread overview]
Message-ID: <20110209205203.344b6a9e@notabene.brown> (raw)
In-Reply-To: <20110209083129.27876.82194.stgit@gklab-128-013.igk.intel.com>
On Wed, 09 Feb 2011 09:31:29 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> Parameters in UT suit 13 were wrongly chosen. This causes that
> computed number of backup blocks was too big comparing to loop devices
> size used in test. Changes in test parameters (chunk, array size)
> causes that backup blocks passes mdadm condition for very small
> loop devices.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
applied,
Thanks,
NeilBrown
> ---
>
> tests/13imsm-r0_r0_2d-grow-r0_r0_5d | 4 ++--
> tests/13imsm-r0_r0_3d-grow-r0_r0_4d | 2 +-
> tests/13imsm-r0_r5_3d-grow-r0_r5_5d | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tests/13imsm-r0_r0_2d-grow-r0_r0_5d b/tests/13imsm-r0_r0_2d-grow-r0_r0_5d
> index 80e0cf0..1b851a9 100644
> --- a/tests/13imsm-r0_r0_2d-grow-r0_r0_5d
> +++ b/tests/13imsm-r0_r0_2d-grow-r0_r0_5d
> @@ -10,13 +10,13 @@ spare_list="$dev2 $dev3 $dev4"
> # Before: RAID 0 volume in slot #0, 2 disks, 64k chunk size
> # RAID 0 volume in slot #1, 2 disks, 256k chunk size
> vol0_level=0
> -vol0_comp_size=$((5 * 1024))
> +vol0_comp_size=$((4 * 1024))
> vol0_chunk=64
> vol0_num_comps=$num_disks
> vol0_offset=0
>
> vol1_level=0
> -vol1_comp_size=$((5 * 1024))
> +vol1_comp_size=$((6 * 1024))
> vol1_chunk=256
> vol1_num_comps=$num_disks
> vol1_offset=$((vol0_comp_size + 2048))
> diff --git a/tests/13imsm-r0_r0_3d-grow-r0_r0_4d b/tests/13imsm-r0_r0_3d-grow-r0_r0_4d
> index 17f24d7..27ba83b 100644
> --- a/tests/13imsm-r0_r0_3d-grow-r0_r0_4d
> +++ b/tests/13imsm-r0_r0_3d-grow-r0_r0_4d
> @@ -17,7 +17,7 @@ vol0_offset=0
>
> vol1_level=0
> vol1_comp_size=$((5 * 1024))
> -vol1_chunk=512
> +vol1_chunk=128
> vol1_num_comps=$num_disks
> vol1_offset=$((vol0_comp_size + 2048))
>
> diff --git a/tests/13imsm-r0_r5_3d-grow-r0_r5_5d b/tests/13imsm-r0_r5_3d-grow-r0_r5_5d
> index 6462d6b..d0db9ae 100644
> --- a/tests/13imsm-r0_r5_3d-grow-r0_r5_5d
> +++ b/tests/13imsm-r0_r5_3d-grow-r0_r5_5d
> @@ -11,13 +11,13 @@ spare_list="$dev3 $dev4"
> # RAID 5 volume in slot #1, 3 disks, 512k chunk size
> vol0_level=0
> vol0_comp_size=$((5 * 1024))
> -vol0_chunk=256
> +vol0_chunk=128
> vol0_num_comps=$num_disks
> vol0_offset=0
>
> vol1_level=5
> vol1_comp_size=$((5 * 1024))
> -vol1_chunk=512
> +vol1_chunk=128
> vol1_num_comps=$((num_disks - 1))
> vol1_offset=$((vol0_comp_size + 2048))
>
prev parent reply other threads:[~2011-02-09 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 8:31 [PATCH] UT FIX: Pass all UT in suit 13 Adam Kwolek
2011-02-09 9:52 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110209205203.344b6a9e@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).