From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 1/4] imsm: FIX: add raid5 to raid0 case to analyse_change()
Date: Mon, 14 Feb 2011 09:26:42 +1100 [thread overview]
Message-ID: <20110214092642.555377e7@notabene.brown> (raw)
In-Reply-To: <20110209134737.4559.34527.stgit@gklab-128-013.igk.intel.com>
On Wed, 09 Feb 2011 14:47:37 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> Transition raid0 to raid5 is not possible
> due to wrong condition in imsm_analyze_change().
> Current condition blocks migration possibility instead allow for it.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Thanks. All 4 in this series applied.
NeilBrown
> ---
>
> super-intel.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 6a21b26..2875ade 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -6934,7 +6934,7 @@ enum imsm_reshape_type imsm_analyze_change(struct supertype *st,
> }
> break;
> case 5:
> - if (geo->level != 0)
> + if (geo->level == 0)
> change = CH_LEVEL_MIGRATION;
> break;
> case 10:
prev parent reply other threads:[~2011-02-13 22:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 13:47 [PATCH 1/4] imsm: FIX: add raid5 to raid0 case to analyse_change() Adam Kwolek
2011-02-09 13:47 ` [PATCH 2/4] imsm: Use single migration type for all migrations Adam Kwolek
2011-02-09 13:47 ` [PATCH 3/4] FIX: array after migration should be unfrozen Adam Kwolek
2011-02-09 13:48 ` [PATCH 4/4] imsm: Add information about failed disk to '-E' option Adam Kwolek
2011-02-13 22:26 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214092642.555377e7@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).