From: Piergiorgio Sartor <piergiorgio.sartor@nexgo.de>
To: NeilBrown <neilb@suse.de>
Cc: Piergiorgio Sartor <piergiorgio.sartor@nexgo.de>,
linux-raid@vger.kernel.org
Subject: Re: [PATCH] Re: User space RAID-6 access
Date: Sat, 19 Feb 2011 00:02:38 +0100 [thread overview]
Message-ID: <20110218230237.GA23883@lazy.lzy> (raw)
In-Reply-To: <20110217172332.2fbb5694@notabene.brown>
> As this is really just for testing, I would add a :offset suffix to the
> device names where the offset is in sectors.
> So:
> /dev/sda
> means read from the start of /dev/sda
>
> /dev/sda:2048
>
> means start 1Meg into /dev/sda.
>
> That should be easy to parse and is quite general.
Hi again,
please find attached below another mini-patch
which should add the offset option, as discussed.
That is, "/dev/sdX:offset".
It should work with or without the ":offset" tail,
and possibly also with "/dev/sdX:", depending on
"atoll()".
Please consider for inclusion.
Thanks,
bye,
diff -uN a/restripe.c b/restripe.c
--- a/restripe.c 2011-02-18 23:18:20.377740868 +0100
+++ b/restripe.c 2011-02-18 23:30:07.589841525 +0100
@@ -875,6 +875,14 @@
exit(3);
}
for (i=0; i<raid_disks; i++) {
+ char *p;
+ p = strchr(argv[9+i], ':');
+
+ if(p != NULL) {
+ *p++ = '\0';
+ offsets[i] = atoll(p) * 512;
+ }
+
fds[i] = open(argv[9+i], O_RDWR);
if (fds[i] < 0) {
perror(argv[9+i]);
--
piergiorgio
prev parent reply other threads:[~2011-02-18 23:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 20:20 User space RAID-6 access Piergiorgio Sartor
2011-01-31 20:52 ` NeilBrown
2011-02-01 19:21 ` Piergiorgio Sartor
2011-02-01 20:14 ` John Robinson
2011-02-01 20:18 ` NeilBrown
2011-02-01 21:00 ` Piergiorgio Sartor
2011-02-05 17:33 ` Piergiorgio Sartor
2011-02-05 20:58 ` NeilBrown
2011-02-07 22:24 ` [PATCH] " Piergiorgio Sartor
2011-02-07 22:49 ` NeilBrown
2011-02-09 18:47 ` Piergiorgio Sartor
2011-02-17 6:23 ` NeilBrown
2011-02-17 20:01 ` Piergiorgio Sartor
2011-02-18 23:02 ` Piergiorgio Sartor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110218230237.GA23883@lazy.lzy \
--to=piergiorgio.sartor@nexgo.de \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).