From mboxrd@z Thu Jan  1 00:00:00 1970
From: NeilBrown <neilb@suse.de>
Subject: Re: [PATCH] Fix over-zealous flush_disk when changing device size.
Date: Tue, 22 Feb 2011 08:14:43 +1100
Message-ID: <20110222081443.6ec89942@notabene.brown>
References: <20110217165057.5c50e566@notabene.brown>
	<x49hbbx18pq.fsf@segfault.boston.devel.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <x49hbbx18pq.fsf@segfault.boston.devel.redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Andrew Patterson <andrew.patterson@hp.com>, Jens Axboe <axboe@kernel.dk>, linux-raid@vger.kernel.org, dm-devel@redhat.com, linux-kernel@vger.kernel.org
List-Id: linux-raid.ids

On Mon, 21 Feb 2011 14:36:01 -0500 Jeff Moyer <jmoyer@redhat.com> wrote:

> NeilBrown <neilb@suse.de> writes:
> 
> > -int __invalidate_device(struct block_device *bdev)
> > +int __invalidate_device2(struct block_device *bdev, bool kill_dirty)
> >  {
> >  	struct super_block *sb = get_super(bdev);
> >  	int res = 0;
> > @@ -1614,7 +1614,7 @@ int __invalidate_device(struct block_device *bdev)
> >  		 * hold).
> >  		 */
> >  		shrink_dcache_sb(sb);
> > -		res = invalidate_inodes(sb);
> > +		res = invalidate_inodes(sb, kill_dirty);
> >  		drop_super(sb);
> >  	}
> >  	invalidate_bdev(bdev);
> 
> Neil, I think you also need to change the EXPORT_SYMBOL from
> __invalidate_device to __invalidate_device2.  The floppy module won't
> build without that change.

Good point, thank.
I've just made this change in mt for-next tree so it should appear in -next
today?

NeilBrown