linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Jan Ceuleers <jan.ceuleers@computer.org>
Cc: "Wojcik, Krzysztof" <krzysztof.wojcik@intel.com>,
	"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>
Subject: Re: Single-drive RAID0
Date: Wed, 23 Feb 2011 13:20:56 +1100	[thread overview]
Message-ID: <20110223132056.4098ec5f@notabene.brown> (raw)
In-Reply-To: <4D63E766.1000104@computer.org>

On Tue, 22 Feb 2011 17:42:14 +0100 Jan Ceuleers <jan.ceuleers@computer.org>
wrote:

> On 22/02/11 01:50, NeilBrown wrote:
> > With the patch, the rescan is only performed when needed and so there
> > are no races.
> 
> Neil,
> 
> If I've properly understood your commit message you are reducing the 
> frequency of the rescans, but they can still occur. I submit that this 
> merely reduces the probability but does not remove the possibility of 
> races with udev.
> 
> If my interpretation is correct, then is this something that should be 
> fixed (to remove the possibility of races altogether), or merely documented?
> 
> Thanks, Jan

Thanks for reviewing the code!!

The patch should reduce the frequency of rescans to just those times when it
is actually needed.
i.e. when the array data first becomes available, and when it stops being
available.
So it will only happen as a direct result of an administrative action.

Previously it could happen at arbitrary times based on open /close/unlink
patterns.

So it isn't really "reducing the frequency" so much as "making it happen only
at well defined times, not arbitrary times".

So this does remove any possibility of races.

Thanks,
NeilBrown


      reply	other threads:[~2011-02-23  2:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 16:15 Single-drive RAID0 Wojcik, Krzysztof
2011-02-09  2:45 ` NeilBrown
2011-02-09 14:33   ` Wojcik, Krzysztof
2011-02-14  2:11     ` NeilBrown
2011-02-14 17:04       ` Wojcik, Krzysztof
2011-02-15  0:01         ` NeilBrown
2011-02-15 16:30           ` Wojcik, Krzysztof
2011-02-16  0:42             ` NeilBrown
2011-02-16 16:57               ` Wojcik, Krzysztof
2011-02-17  0:38                 ` NeilBrown
2011-02-21  2:15                 ` NeilBrown
2011-02-21 14:11                   ` Wojcik, Krzysztof
2011-02-22  0:50                     ` NeilBrown
2011-02-22 11:50                       ` Wojcik, Krzysztof
2011-02-22 16:42                       ` Jan Ceuleers
2011-02-23  2:20                         ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110223132056.4098ec5f@notabene.brown \
    --to=neilb@suse.de \
    --cc=jan.ceuleers@computer.org \
    --cc=krzysztof.wojcik@intel.com \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).