From: NeilBrown <neilb@suse.de>
To: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
Cc: linux-raid@vger.kernel.org, wojciech.neubauer@intel.com,
adam.kwolek@intel.com, dan.j.williams@intel.com,
ed.ciechanowski@intel.com
Subject: Re: [PATCH] Enable error message in case of lack of spares for grow
Date: Tue, 8 Mar 2011 09:53:21 +1100 [thread overview]
Message-ID: <20110308095321.045cf904@notabene.brown> (raw)
In-Reply-To: <20110302163301.5135.68810.stgit@gklab-128-111.igk.intel.com>
On Wed, 02 Mar 2011 17:33:01 +0100 Krzysztof Wojcik
<krzysztof.wojcik@intel.com> wrote:
> When we cannot find spare devices for grow operation we should
> print error message.
> This patch changes debug error message to 'stderr' print.
>
> Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
> ---
> super-intel.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 5b09bc5..fde29b8 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -7112,7 +7112,8 @@ static int imsm_create_metadata_update_for_reshape(
>
> if (spares == NULL
> || delta_disks > spares->array.spare_disks) {
> - dprintf("imsm: ERROR: Cannot get spare devices.\n");
> + fprintf(stderr, Name ": imsm: ERROR: Cannot get spare devices "
> + "for %s.\n", geo->dev_name);
> goto abort;
> }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied,
thanks.
NeilBrown
prev parent reply other threads:[~2011-03-07 22:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 16:33 [PATCH] Enable error message in case of lack of spares for grow Krzysztof Wojcik
2011-03-07 22:53 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308095321.045cf904@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=krzysztof.wojcik@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).