* [PATCH] Enable error message in case of lack of spares for grow
@ 2011-03-02 16:33 Krzysztof Wojcik
2011-03-07 22:53 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Wojcik @ 2011-03-02 16:33 UTC (permalink / raw)
To: neilb
Cc: linux-raid, wojciech.neubauer, adam.kwolek, dan.j.williams,
ed.ciechanowski
When we cannot find spare devices for grow operation we should
print error message.
This patch changes debug error message to 'stderr' print.
Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
---
super-intel.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/super-intel.c b/super-intel.c
index 5b09bc5..fde29b8 100644
--- a/super-intel.c
+++ b/super-intel.c
@@ -7112,7 +7112,8 @@ static int imsm_create_metadata_update_for_reshape(
if (spares == NULL
|| delta_disks > spares->array.spare_disks) {
- dprintf("imsm: ERROR: Cannot get spare devices.\n");
+ fprintf(stderr, Name ": imsm: ERROR: Cannot get spare devices "
+ "for %s.\n", geo->dev_name);
goto abort;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Enable error message in case of lack of spares for grow
2011-03-02 16:33 [PATCH] Enable error message in case of lack of spares for grow Krzysztof Wojcik
@ 2011-03-07 22:53 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2011-03-07 22:53 UTC (permalink / raw)
To: Krzysztof Wojcik
Cc: linux-raid, wojciech.neubauer, adam.kwolek, dan.j.williams,
ed.ciechanowski
On Wed, 02 Mar 2011 17:33:01 +0100 Krzysztof Wojcik
<krzysztof.wojcik@intel.com> wrote:
> When we cannot find spare devices for grow operation we should
> print error message.
> This patch changes debug error message to 'stderr' print.
>
> Signed-off-by: Krzysztof Wojcik <krzysztof.wojcik@intel.com>
> ---
> super-intel.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 5b09bc5..fde29b8 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -7112,7 +7112,8 @@ static int imsm_create_metadata_update_for_reshape(
>
> if (spares == NULL
> || delta_disks > spares->array.spare_disks) {
> - dprintf("imsm: ERROR: Cannot get spare devices.\n");
> + fprintf(stderr, Name ": imsm: ERROR: Cannot get spare devices "
> + "for %s.\n", geo->dev_name);
> goto abort;
> }
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied,
thanks.
NeilBrown
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-07 22:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-02 16:33 [PATCH] Enable error message in case of lack of spares for grow Krzysztof Wojcik
2011-03-07 22:53 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).