From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 3/9] FIX: Make expansion counter usable
Date: Thu, 10 Mar 2011 11:28:30 +1100 [thread overview]
Message-ID: <20110310112830.7d292125@notabene.brown> (raw)
In-Reply-To: <20110309134554.8939.74177.stgit@gklab-128-013.igk.intel.com>
On Wed, 09 Mar 2011 14:45:54 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> Currently whole array geometry is set in sysfs_set_array(),
> so none of disks (even for expansion) should fail during sysfs_add_disk()
> Due to this expansion counter should be used for reshaped array when
> disk slot is bigger than number of disks in array.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> Assemble.c | 13 +++++++------
> 1 files changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/Assemble.c b/Assemble.c
> index fe917b2..0ffbbc9 100644
> --- a/Assemble.c
> +++ b/Assemble.c
> @@ -1526,13 +1526,14 @@ int assemble_container_content(struct supertype *st, int mdfd,
> sysfs_free(sra);
>
> for (dev = content->devs; dev; dev = dev->next)
> - if (sysfs_add_disk(content, dev, 1) == 0)
> - working++;
> - else if (errno == EEXIST)
> + if (sysfs_add_disk(content, dev, 1) == 0) {
> + if (dev->disk.raid_disk >= content->array.raid_disks &&
> + content->reshape_active)
> + expansion++;
> + else
> + working++;
> + } else if (errno == EEXIST)
> preexist++;
> - else if (dev->disk.raid_disk >= content->array.raid_disks &&
> - content->reshape_active)
> - expansion++;
> if (working == 0)
> return 1;/* Nothing new, don't try to start */
>
>
Applied, thanks.
NeilBrown
next prev parent reply other threads:[~2011-03-10 0:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 13:45 [PATCH 0/9] Reshape restart from checkpoint Adam Kwolek
2011-03-09 13:45 ` [PATCH 1/9] FIX: Load container content for container reshape continuation Adam Kwolek
2011-03-10 0:27 ` NeilBrown
2011-03-09 13:45 ` [PATCH 2/9] FIX: Block reshaped array monitoring Adam Kwolek
2011-03-10 0:28 ` NeilBrown
2011-03-09 13:45 ` [PATCH 3/9] FIX: Make expansion counter usable Adam Kwolek
2011-03-10 0:28 ` NeilBrown [this message]
2011-03-09 13:46 ` [PATCH 4/9] imsm: FIX: Do not clean checkpoint for active reshape Adam Kwolek
2011-03-10 0:33 ` NeilBrown
2011-03-09 13:46 ` [PATCH 5/9] FIX: Unfreeze array on success only during reshape continuation Adam Kwolek
2011-03-10 0:36 ` NeilBrown
2011-03-09 13:46 ` [PATCH 6/9] FIX: Cannot continue reshape if mdmon is not run Adam Kwolek
2011-03-10 0:37 ` NeilBrown
2011-03-09 13:46 ` [PATCH 7/9] FIX: Array cannot be opened for writing on restart Adam Kwolek
2011-03-10 0:38 ` NeilBrown
2011-03-09 13:46 ` [PATCH 8/9] FIX: Set 'active' array state before array configuration Adam Kwolek
2011-03-10 0:39 ` NeilBrown
2011-03-09 13:46 ` [PATCH 9/9] imsm : FIX: Assemble dirty array when reshape is in progress Adam Kwolek
2011-03-10 0:39 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310112830.7d292125@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).