From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 5/9] FIX: Unfreeze array on success only during reshape continuation
Date: Thu, 10 Mar 2011 11:36:23 +1100 [thread overview]
Message-ID: <20110310113623.56091fae@notabene.brown> (raw)
In-Reply-To: <20110309134610.8939.79769.stgit@gklab-128-013.igk.intel.com>
On Wed, 09 Mar 2011 14:46:10 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> When reshape continuation fails, reshaped array should remain frozen
> to allow user for repair action (mdmon will not change array state).
> Setting restart to 0 was moved down to allow failure detection.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> Grow.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/Grow.c b/Grow.c
> index e37fc57..67bbb26 100644
> --- a/Grow.c
> +++ b/Grow.c
> @@ -2255,11 +2255,12 @@ int reshape_container(char *container, char *devname,
> content, force,
> backup_file, quiet, 1, restart);
> close(fd);
> - restart = 0;
> if (rv)
> break;
> + restart = 0;
> }
> - unfreeze(st);
> + if (restart == 0)
> + unfreeze(st);
> sysfs_free(cc);
> exit(0);
> }
>
Not applied... it is probably close to right, but I'm a little confused.
Surely we should never never unfreeze on an error - not only in the restart
case...
And the code doesn't make it obvious that the unfreeze is only in the
error case...
Maybe
if (!rv)
unfreeze(st);
??
NeilBrown
next prev parent reply other threads:[~2011-03-10 0:36 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 13:45 [PATCH 0/9] Reshape restart from checkpoint Adam Kwolek
2011-03-09 13:45 ` [PATCH 1/9] FIX: Load container content for container reshape continuation Adam Kwolek
2011-03-10 0:27 ` NeilBrown
2011-03-09 13:45 ` [PATCH 2/9] FIX: Block reshaped array monitoring Adam Kwolek
2011-03-10 0:28 ` NeilBrown
2011-03-09 13:45 ` [PATCH 3/9] FIX: Make expansion counter usable Adam Kwolek
2011-03-10 0:28 ` NeilBrown
2011-03-09 13:46 ` [PATCH 4/9] imsm: FIX: Do not clean checkpoint for active reshape Adam Kwolek
2011-03-10 0:33 ` NeilBrown
2011-03-09 13:46 ` [PATCH 5/9] FIX: Unfreeze array on success only during reshape continuation Adam Kwolek
2011-03-10 0:36 ` NeilBrown [this message]
2011-03-09 13:46 ` [PATCH 6/9] FIX: Cannot continue reshape if mdmon is not run Adam Kwolek
2011-03-10 0:37 ` NeilBrown
2011-03-09 13:46 ` [PATCH 7/9] FIX: Array cannot be opened for writing on restart Adam Kwolek
2011-03-10 0:38 ` NeilBrown
2011-03-09 13:46 ` [PATCH 8/9] FIX: Set 'active' array state before array configuration Adam Kwolek
2011-03-10 0:39 ` NeilBrown
2011-03-09 13:46 ` [PATCH 9/9] imsm : FIX: Assemble dirty array when reshape is in progress Adam Kwolek
2011-03-10 0:39 ` NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310113623.56091fae@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).