From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 9/9] imsm : FIX: Assemble dirty array when reshape is in progress
Date: Thu, 10 Mar 2011 11:39:26 +1100 [thread overview]
Message-ID: <20110310113926.1c85810b@notabene.brown> (raw)
In-Reply-To: <20110309134642.8939.6587.stgit@gklab-128-013.igk.intel.com>
On Wed, 09 Mar 2011 14:46:42 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:
> During reshape for dirty volumes reshape_progress has to be calculated also.
> To keep the same logic for array creation:
> not setting info->resync_start = MaxSector when first condition is true,
> resync_start is initialized by MaxSector to allow proper array initialization.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
> ---
>
> super-intel.c | 7 ++++---
> 1 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 4e3de8a..38756e2 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -1820,10 +1820,12 @@ static void getinfo_super_imsm_volume(struct supertype *st, struct mdinfo *info,
> info->recovery_start = MaxSector;
>
> info->reshape_progress = 0;
> + info->resync_start = MaxSector;
> if (map_to_analyse->map_state == IMSM_T_STATE_UNINITIALIZED ||
> dev->vol.dirty) {
> info->resync_start = 0;
> - } else if (dev->vol.migr_state) {
> + }
> + if (dev->vol.migr_state) {
> switch (migr_type(dev)) {
> case MIGR_REPAIR:
> case MIGR_INIT: {
> @@ -1868,8 +1870,7 @@ static void getinfo_super_imsm_volume(struct supertype *st, struct mdinfo *info,
> /* we are not dirty, so... */
> info->resync_start = MaxSector;
> }
> - } else
> - info->resync_start = MaxSector;
> + }
>
> strncpy(info->name, (char *) dev->volume, MAX_RAID_SERIAL_LEN);
> info->name[MAX_RAID_SERIAL_LEN] = 0;
Applied, thanks.
NeilBrown
prev parent reply other threads:[~2011-03-10 0:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 13:45 [PATCH 0/9] Reshape restart from checkpoint Adam Kwolek
2011-03-09 13:45 ` [PATCH 1/9] FIX: Load container content for container reshape continuation Adam Kwolek
2011-03-10 0:27 ` NeilBrown
2011-03-09 13:45 ` [PATCH 2/9] FIX: Block reshaped array monitoring Adam Kwolek
2011-03-10 0:28 ` NeilBrown
2011-03-09 13:45 ` [PATCH 3/9] FIX: Make expansion counter usable Adam Kwolek
2011-03-10 0:28 ` NeilBrown
2011-03-09 13:46 ` [PATCH 4/9] imsm: FIX: Do not clean checkpoint for active reshape Adam Kwolek
2011-03-10 0:33 ` NeilBrown
2011-03-09 13:46 ` [PATCH 5/9] FIX: Unfreeze array on success only during reshape continuation Adam Kwolek
2011-03-10 0:36 ` NeilBrown
2011-03-09 13:46 ` [PATCH 6/9] FIX: Cannot continue reshape if mdmon is not run Adam Kwolek
2011-03-10 0:37 ` NeilBrown
2011-03-09 13:46 ` [PATCH 7/9] FIX: Array cannot be opened for writing on restart Adam Kwolek
2011-03-10 0:38 ` NeilBrown
2011-03-09 13:46 ` [PATCH 8/9] FIX: Set 'active' array state before array configuration Adam Kwolek
2011-03-10 0:39 ` NeilBrown
2011-03-09 13:46 ` [PATCH 9/9] imsm : FIX: Assemble dirty array when reshape is in progress Adam Kwolek
2011-03-10 0:39 ` NeilBrown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310113926.1c85810b@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).