linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
	ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH 0/2] Checkpointing fixes
Date: Mon, 14 Mar 2011 18:22:11 +1100	[thread overview]
Message-ID: <20110314182211.77d6dce8@notabene.brown> (raw)
In-Reply-To: <20110311115051.12324.75830.stgit@gklab-128-013.igk.intel.com>

On Fri, 11 Mar 2011 12:59:04 +0100 Adam Kwolek <adam.kwolek@intel.com> wrote:

> The following series implements fixes for checkpointing.
> I've observe that restart from checkpoint occurs too far in array (it skipped some area).
> It happen due to wrong initialization of last_checkpoint field. It has to be done in per disk units,
> but setting it to reshape_position value causes initialization in per array units (multiplied by number of data disks)
> First patch fixes this.
> To keep checkpoint calculation consistent, I've decided to do similar thing for imsm (2'nd patch) and keep checkpoints 
> per disk. During reshape_progress initialization it is recalculated in to reshape position.
> 
> This patches has to be applied on my yesterdays fixes.
> 
> BR
> Adam
> 
> 
> ---
> 
> Adam Kwolek (2):
>       imsm: FIX: Store checkpoint in per disk units
>       FIX: Last_checkpoint has to be initialized in per disk units
> 
> 
>  managemon.c   |    9 +++++++++
>  super-intel.c |    8 ++++++--
>  2 files changed, 15 insertions(+), 2 deletions(-)
> 


Thanks - I've applied these and the other two you sent.

NeilBrown


      parent reply	other threads:[~2011-03-14  7:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11 11:59 [PATCH 0/2] Checkpointing fixes Adam Kwolek
2011-03-11 11:59 ` [PATCH 1/2] FIX: Last_checkpoint has to be initialized in per disk units Adam Kwolek
2011-03-11 11:59 ` [PATCH 2/2] imsm: FIX: Store checkpoint " Adam Kwolek
2011-03-14  7:22 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110314182211.77d6dce8@notabene.brown \
    --to=neilb@suse.de \
    --cc=adam.kwolek@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ed.ciechanowski@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=wojciech.neubauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).