* blk_flush_plug in the MD code, was Re: [xfs-masters] linux-next: manual merge of the xfs tree with Linus' tree
[not found] ` <4D93177B.50505@fusionio.com>
@ 2011-03-30 11:57 ` Christoph Hellwig
0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2011-03-30 11:57 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-kernel, linux-raid, neilb
On Wed, Mar 30, 2011 at 01:43:55PM +0200, Jens Axboe wrote:
> On 2011-03-29 22:08, Christoph Hellwig wrote:
> > FYI, the blk_flush_plug call in ufs_truncate also seem to be almost
> > certainly incorrect as it's followed by a yield.
> >
> > That only leaves the RAID code as remaining modular users of it, and
> > I suspect it really is something that shouldn't need to be exported.
>
> Agree, once things have settled down we can reap the remaining and keep
> it internal.
In fact I think the blk_flush_plug calls in the raid1/raid10 code can
simply be removed without a replacement. They are in wait_even_loops
which schedule before/after the call so we do get the implicit context
switch plugs there. Even more they are generally called from the
make_request handler, which for MD is in the loop around
__generic_make_request and thus can't actually unplug in a sensible
way.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-03-30 11:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20110328122148.1b48a742.sfr@canb.auug.org.au>
[not found] ` <20110328104753.GA27327@lst.de>
[not found] ` <20110328105348.GA27458@lst.de>
[not found] ` <4D9069C1.4080602@fusionio.com>
[not found] ` <20110329200813.GA9687@lst.de>
[not found] ` <4D93177B.50505@fusionio.com>
2011-03-30 11:57 ` blk_flush_plug in the MD code, was Re: [xfs-masters] linux-next: manual merge of the xfs tree with Linus' tree Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).