linux-raid.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Adam Kwolek <adam.kwolek@intel.com>
Cc: linux-raid@vger.kernel.org, dan.j.williams@intel.com,
	ed.ciechanowski@intel.com, wojciech.neubauer@intel.com
Subject: Re: [PATCH] FIX: After discarding array give chance monitor to remove it
Date: Tue, 5 Apr 2011 09:32:04 +1000	[thread overview]
Message-ID: <20110405093204.75efadb7@notabene.brown> (raw)
In-Reply-To: <20110328115648.13950.11803.stgit@gklab-128-013.igk.intel.com>

On Mon, 28 Mar 2011 13:56:49 +0200 Adam Kwolek <adam.kwolek@intel.com> wrote:

> When raid0 expansion occurs, takeover operation is used.
> After backward takeover monitor remains in memory.
> 
> This happens due to remaining just removed active array in mdmon structures.
> If there is no other monitored arrays, mdmon has to finish his work.
> 
> Problem was introduced in patch (2011.03.22):
>     mdmon: Stop keeping track of RAID0 (and LINEAR) arrays.
> Prior to this patch mdmon kicking occurs via replace_array() where
> wakeup_monitor() was called.
> 
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>

Applied - thanks.

NeilBrown


> ---
> 
>  managemon.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/managemon.c b/managemon.c
> index 67c5951..6662f67 100644
> --- a/managemon.c
> +++ b/managemon.c
> @@ -462,6 +462,7 @@ static void manage_member(struct mdstat_ent *mdstat,
>  		int level = map_name(pers, mdstat->level);
>  		if (level == 0 || level == LEVEL_LINEAR) {
>  			a->container = NULL;
> +			wakeup_monitor();
>  			return;
>  		}
>  		else if (a->info.array.level != level && level > 0) {


      reply	other threads:[~2011-04-04 23:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-28 11:56 [PATCH] FIX: After discarding array give chance monitor to remove it Adam Kwolek
2011-04-04 23:32 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110405093204.75efadb7@notabene.brown \
    --to=neilb@suse.de \
    --cc=adam.kwolek@intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ed.ciechanowski@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=wojciech.neubauer@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).