* [PATCH] FIX: After discarding array give chance monitor to remove it
@ 2011-03-28 11:56 Adam Kwolek
2011-04-04 23:32 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: Adam Kwolek @ 2011-03-28 11:56 UTC (permalink / raw)
To: neilb; +Cc: linux-raid, dan.j.williams, ed.ciechanowski, wojciech.neubauer
When raid0 expansion occurs, takeover operation is used.
After backward takeover monitor remains in memory.
This happens due to remaining just removed active array in mdmon structures.
If there is no other monitored arrays, mdmon has to finish his work.
Problem was introduced in patch (2011.03.22):
mdmon: Stop keeping track of RAID0 (and LINEAR) arrays.
Prior to this patch mdmon kicking occurs via replace_array() where
wakeup_monitor() was called.
Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
---
managemon.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/managemon.c b/managemon.c
index 67c5951..6662f67 100644
--- a/managemon.c
+++ b/managemon.c
@@ -462,6 +462,7 @@ static void manage_member(struct mdstat_ent *mdstat,
int level = map_name(pers, mdstat->level);
if (level == 0 || level == LEVEL_LINEAR) {
a->container = NULL;
+ wakeup_monitor();
return;
}
else if (a->info.array.level != level && level > 0) {
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] FIX: After discarding array give chance monitor to remove it
2011-03-28 11:56 [PATCH] FIX: After discarding array give chance monitor to remove it Adam Kwolek
@ 2011-04-04 23:32 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2011-04-04 23:32 UTC (permalink / raw)
To: Adam Kwolek
Cc: linux-raid, dan.j.williams, ed.ciechanowski, wojciech.neubauer
On Mon, 28 Mar 2011 13:56:49 +0200 Adam Kwolek <adam.kwolek@intel.com> wrote:
> When raid0 expansion occurs, takeover operation is used.
> After backward takeover monitor remains in memory.
>
> This happens due to remaining just removed active array in mdmon structures.
> If there is no other monitored arrays, mdmon has to finish his work.
>
> Problem was introduced in patch (2011.03.22):
> mdmon: Stop keeping track of RAID0 (and LINEAR) arrays.
> Prior to this patch mdmon kicking occurs via replace_array() where
> wakeup_monitor() was called.
>
> Signed-off-by: Adam Kwolek <adam.kwolek@intel.com>
Applied - thanks.
NeilBrown
> ---
>
> managemon.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/managemon.c b/managemon.c
> index 67c5951..6662f67 100644
> --- a/managemon.c
> +++ b/managemon.c
> @@ -462,6 +462,7 @@ static void manage_member(struct mdstat_ent *mdstat,
> int level = map_name(pers, mdstat->level);
> if (level == 0 || level == LEVEL_LINEAR) {
> a->container = NULL;
> + wakeup_monitor();
> return;
> }
> else if (a->info.array.level != level && level > 0) {
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-04 23:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-28 11:56 [PATCH] FIX: After discarding array give chance monitor to remove it Adam Kwolek
2011-04-04 23:32 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).