From: NeilBrown <neilb@suse.de>
To: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com>
Cc: linux-raid@vger.kernel.org, wojciech.neubauer@intel.com,
adam.kwolek@intel.com, dan.j.williams@intel.com,
ed.ciechanowski@intel.com
Subject: Re: [PATCH 1/5] imsm: prepare update for level migrations reshape
Date: Mon, 2 May 2011 16:15:10 +1000 [thread overview]
Message-ID: <20110502161510.6a226302@notabene.brown> (raw)
In-Reply-To: <20110428220005.19632.12064.stgit@gklab-128-081.igk.intel.com>
On Fri, 29 Apr 2011 00:00:05 +0200 Przemyslaw Czarnowski
<przemyslaw.hawrylewicz.czarnowski@intel.com> wrote:
struct intel_dev *dv;
> @@ -7025,12 +7046,12 @@ static int imsm_create_metadata_update_for_reshape(
> struct supertype *st,
> struct geo_params *geo,
> int old_raid_disks,
> - struct imsm_update_reshape **updatep)
> + struct imsm_update_reshape_migration **updatep)
> {
Why are you changing the type of 'updatep' for
imsm_create_metadata_update_for_reshape?
The subsequent code allocated memory based on the 'imsm_update_reshape'
structure, but then sets 'new_disk' entries based on the new structure.
That has got to be wrong.
Please review and fix this up.
NeilBrown
next prev parent reply other threads:[~2011-05-02 6:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 21:59 [PATCH 0/5] Support for IMSM raid0->raid5 migration Przemyslaw Czarnowski
2011-04-28 22:00 ` [PATCH 1/5] imsm: prepare update for level migrations reshape Przemyslaw Czarnowski
2011-05-02 6:15 ` NeilBrown [this message]
2011-04-28 22:00 ` [PATCH 2/5] imsm: fix: disable migration from raid5->raid0 Przemyslaw Czarnowski
2011-04-28 22:01 ` [PATCH 3/5] imsm: prepare memory for level migration update Przemyslaw Czarnowski
2011-04-28 22:01 ` [PATCH 4/5] imsm: process update for raid level migrations Przemyslaw Czarnowski
2011-04-28 22:02 ` [PATCH 5/5] imsm: add new chunk size to metadata update Przemyslaw Czarnowski
-- strict thread matches above, loose matches on Subject: below --
2011-05-04 15:10 [PATCH 0/5] imsm support for raid0->raid5 migration Przemyslaw Czarnowski
2011-05-04 15:11 ` [PATCH 1/5] imsm: prepare update for level migrations reshape Przemyslaw Czarnowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502161510.6a226302@notabene.brown \
--to=neilb@suse.de \
--cc=adam.kwolek@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ed.ciechanowski@intel.com \
--cc=linux-raid@vger.kernel.org \
--cc=przemyslaw.hawrylewicz.czarnowski@intel.com \
--cc=wojciech.neubauer@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).